r103459 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r103458‎ | r103459 | r103460 >
Date:12:41, 17 November 2011
Author:catrope
Status:ok (Comments)
Tags:
Comment:
1.18wmf1: MFT r103456
Modified paths:
  • /branches/wmf/1.18wmf1/extensions/ArticleFeedback/modules/ext.articleFeedback/ext.articleFeedback.startup.js (modified) (history)
  • /branches/wmf/1.18wmf1/extensions/ArticleFeedback/modules/jquery.articleFeedback/jquery.articleFeedback.js (modified) (history)

Diff [purge]

Index: branches/wmf/1.18wmf1/extensions/ArticleFeedback/modules/jquery.articleFeedback/jquery.articleFeedback.js
——@@ -3,12 +3,6 @@
44 */
55
66 ( function( $ ) {
7 -// HACK: This code is broken in IE7 and below, so if this is IE < 8, bail now
8 -var browser = $.client.profile();
9 -if ( browser.name === 'msie' && browser.versionNumber < 8 ) {
10 - return;
11 -}
12 -
137 // Only track users who have been assigned to the tracking group
148 var tracked = 'track' === mw.user.bucket(
159 'ext.articleFeedback-tracking', mw.config.get( 'wgArticleFeedbackTracking' )
Index: branches/wmf/1.18wmf1/extensions/ArticleFeedback/modules/ext.articleFeedback/ext.articleFeedback.startup.js
——@@ -3,6 +3,12 @@
44 */
55
66 jQuery( function( $ ) {
 7+ // HACK: This code is broken in IE7 and below, so if this is IE < 8, bail now
 8+ var browser = $.client.profile();
 9+ if ( browser.name === 'msie' && browser.versionNumber < 8 ) {
 10+ return;
 11+ }
 12+
713 // Load check, is this page ArticleFeedback-enabled ?
814 // Keep in sync with ApiArticleFeedback.php
915 if (

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r103456Followup r101461: per CR, move the code detecting IE7 and below to ext.articl...catrope12:37, 17 November 2011

Comments

#Comment by NeilK (talk | contribs)   01:02, 18 November 2011

This code is committed to 1.18wmf1 but as far as I can tell was not actually deployed. As such I held it back from a deploy that I just did.

But it is now sitting in php-1.18 on fenari, so the next deploy WILL deploy this code. If this is not what you were intending, please fix it.

#Comment by Catrope (talk | contribs)   11:03, 19 November 2011

Grah, apologies. I'll deploy it now.

Status & tagging log