r101461 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r101460‎ | r101461 | r101462 >
Date:08:53, 1 November 2011
Author:catrope
Status:resolved
Tags:
Comment:
Hack for bug 31543: disable ArticleFeedback on IE7 and below
Modified paths:
  • /trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/jquery.articleFeedback.js (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/jquery.articleFeedback.js
@@ -3,6 +3,11 @@
44 */
55
66 ( function( $ ) {
 7+// HACK: This code is broken in IE7 and below, so if this is IE < 8, bail now
 8+var browser = $.client.profile();
 9+if ( browser.name === 'msie' && browser.versionNumber < 8 ) {
 10+ return;
 11+}
712
813 // Only track users who have been assigned to the tracking group
914 var tracked = 'track' === mw.user.bucket(

Follow-up revisions

RevisionCommit summaryAuthorDate
r1014621.18wmf1: MFT r101461catrope08:58, 1 November 2011
r103456Followup r101461: per CR, move the code detecting IE7 and below to ext.articl...catrope12:37, 17 November 2011

Status & tagging log