r103457 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r103456‎ | r103457 | r103458 >
Date:12:39, 17 November 2011
Author:reedy
Status:ok
Tags:
Comment:
Bug 32458 - Special:BlockList doesn't work

PHP Fatal error: Call to undefined method BlockListPager::getLang() in
/var/www/1.18/w/includes/specials/SpecialBlockList.php on line 247

Fixed similar on 273 also

Fixed $this->getUser() on line 274


Would seem in REL1_18, the pagers haven't had context source somewhere higher up
Modified paths:
  • /branches/REL1_18/phase3/includes/specials/SpecialBlockList.php (modified) (history)

Diff [purge]

Index: branches/REL1_18/phase3/includes/specials/SpecialBlockList.php
——@@ -244,7 +244,7 @@
245245
246246 switch( $name ) {
247247 case 'ipb_timestamp':
248 - $formatted = $this->getLang()->timeanddate( $value, /* User preference timezone */ true );
 248+ $formatted = $wgLang->timeanddate( $value, /* User preference timezone */ true );
249249 break;
250250
251251 case 'ipb_target':
——@@ -270,8 +270,8 @@
271271 break;
272272
273273 case 'ipb_expiry':
274 - $formatted = $this->getLang()->formatExpiry( $value, /* User preference timezone */ true );
275 - if( $this->getUser()->isAllowed( 'block' ) ){
 274+ $formatted = $wgLang->formatExpiry( $value, /* User preference timezone */ true );
 275+ if( $wgUser->isAllowed( 'block' ) ){
276276 if( $row->ipb_auto ){
277277 $links[] = $sk->linkKnown(
278278 SpecialPage::getTitleFor( 'Unblock' ),

Follow-up revisions

RevisionCommit summaryAuthorDate
r103458Deleting REL1_18_0rc1 tag after r103457reedy12:40, 17 November 2011

Status & tagging log