r100843 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r100842‎ | r100843 | r100844 >
Date:18:56, 26 October 2011
Author:awjrichards
Status:ok
Tags:fundraising 
Comment:
Revert r100839. I misunderstood what exactly loadPlaceholders was already doing in TwoStepTwoColumnLetter3
Modified paths:
  • /trunk/extensions/DonationInterface/gateway_forms/TwoStepTwoColumnLetter3.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/gateway_forms/TwoStepTwoColumnLetter3.php
@@ -8,8 +8,18 @@
99 if ( !strlen( $this->getStylePath() ) ) {
1010 $this->setStylePath( $wgExtensionAssetsPath . '/DonationInterface/gateway_forms/css/TwoStepTwoColumnLetter3.css' );
1111 }
 12+ $this->loadvalidateJs();
1213 parent::__construct( $gateway, $form_errors );
1314 }
 15+
 16+ /**
 17+ * Load resources required by this form
 18+ *
 19+ * @see parent::loadResources()
 20+ */
 21+ public function loadResources() {
 22+ $this->loadValidateJs();
 23+ }
1424
1525 public function loadPlaceholders() {
1626 global $wgOut;

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r100839Fixing redundat loadResources() call in TwoStepTwoColumnLetter3 form because ...awjrichards18:43, 26 October 2011

Status & tagging log