r100065 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r100064‎ | r100065 | r100066 >
Date:18:08, 17 October 2011
Author:preilly
Status:ok (Comments)
Tags:
Comment:
part of the fix for bug 31773 - mobile view has invalid html structure
Modified paths:
  • /trunk/extensions/MobileFrontend/views/layout/application.html.php (modified) (history)

Diff [purge]

Index: trunk/extensions/MobileFrontend/views/layout/application.html.php
——@@ -15,9 +15,8 @@
1616 $cssFileName = ( isset( self::$device['css_file_name'] ) ) ? self::$device['css_file_name'] : 'default';
1717
1818 $applicationHtml = <<<EOT
19 -<!DOCTYPE html PUBLIC
20 - "-//WAPFORUM//DTD XHTML Mobile 1.2//EN"
21 - "http://www.openmobilealliance.org/tech/DTD/xhtml-mobile12.dtd">
 19+<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
 20+"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
2221 <html lang='{$code}' dir='{$dir}' xml:lang='{$code}' xmlns='http://www.w3.org/1999/xhtml'>
2322 <head>
2423 <title>{$htmlTitle}</title>

Follow-up revisions

RevisionCommit summaryAuthorDate
r100066mft r100065preilly18:09, 17 October 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r100056part of the fix for bug 31773 - mobile view has invalid html structurepreilly17:42, 17 October 2011
r100057part of the fix for bug 31773 - mobile view has invalid html structurepreilly17:48, 17 October 2011
r100059part of the fix for bug 31773 - mobile view has invalid html structurepreilly17:53, 17 October 2011
r100062part of the fix for bug 31773 - mobile view has invalid html structurepreilly18:03, 17 October 2011

Comments

#Comment by G.Hagedorn (talk | contribs)   11:13, 18 October 2011

applied to 1.18wmf1, please consider tagging 1.18

Status & tagging log