r100062 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r100061‎ | r100062 | r100063 >
Date:18:03, 17 October 2011
Author:preilly
Status:ok (Comments)
Tags:
Comment:
part of the fix for bug 31773 - mobile view has invalid html structure
Modified paths:
  • /trunk/extensions/MobileFrontend/MobileFrontend.php (modified) (history)

Diff [purge]

Index: trunk/extensions/MobileFrontend/MobileFrontend.php
@@ -1080,7 +1080,9 @@
10811081 if ( $redLink->hasAttributes() ) {
10821082 $attributes = $redLink->attributes;
10831083 foreach ( $attributes as $i => $attribute ) {
1084 - $spanNode->setAttribute( $attribute->name, $attribute->value );
 1084+ if ( $attribute->name != 'href' ) {
 1085+ $spanNode->setAttribute( $attribute->name, $attribute->value );
 1086+ }
10851087 }
10861088 }
10871089

Follow-up revisions

RevisionCommit summaryAuthorDate
r100063mft r100062preilly18:04, 17 October 2011
r100065part of the fix for bug 31773 - mobile view has invalid html structurepreilly18:08, 17 October 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r100056part of the fix for bug 31773 - mobile view has invalid html structurepreilly17:42, 17 October 2011
r100057part of the fix for bug 31773 - mobile view has invalid html structurepreilly17:48, 17 October 2011
r100059part of the fix for bug 31773 - mobile view has invalid html structurepreilly17:53, 17 October 2011

Comments

#Comment by G.Hagedorn (talk | contribs)   11:14, 18 October 2011

applied to 1.18wmf1, please consider tagging 1.18

Status & tagging log