r100057 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r100056‎ | r100057 | r100058 >
Date:17:48, 17 October 2011
Author:preilly
Status:ok (Comments)
Tags:
Comment:
part of the fix for bug 31773 - mobile view has invalid html structure
Modified paths:
  • /trunk/extensions/MobileFrontend/MobileFrontend.php (modified) (history)

Diff [purge]

Index: trunk/extensions/MobileFrontend/MobileFrontend.php
@@ -248,7 +248,7 @@
249249 throw new HttpError( 500, $message );
250250 } else {
251251 $parsedUrl = wfParseUrl( $targetUrl );
252 - if ( stristr( $parsedUrl['host'], $wgMobileDomain ) === FALSE ) {
 252+ if ( stristr( $parsedUrl['host'], $wgMobileDomain ) === false ) {
253253 $hostParts = explode( '.', $parsedUrl['host'] );
254254 $parsedUrl['host'] = $hostParts[0] . $wgMobileDomain . $hostParts[1] . '.' . $hostParts[2];
255255 }
@@ -314,6 +314,10 @@
315315
316316 $skin = $wgUser->getSkin();
317317 $copyright = $skin->getCopyright();
 318+ if ( stristr( $copyright, '<li>' ) !== false ) {
 319+ $copyright = '<ul><li>' . $copyright . '</li></ul>';
 320+ }
 321+
318322 // Need to stash the results of the "wfMsg" call before the Output Buffering handler
319323 // because at this point the database connection is shut down, etc.
320324

Follow-up revisions

RevisionCommit summaryAuthorDate
r100058mft r100056 r100057preilly17:50, 17 October 2011
r100059part of the fix for bug 31773 - mobile view has invalid html structurepreilly17:53, 17 October 2011
r100062part of the fix for bug 31773 - mobile view has invalid html structurepreilly18:03, 17 October 2011
r100065part of the fix for bug 31773 - mobile view has invalid html structurepreilly18:08, 17 October 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r100056part of the fix for bug 31773 - mobile view has invalid html structurepreilly17:42, 17 October 2011

Comments

#Comment by G.Hagedorn (talk | contribs)   11:14, 18 October 2011

applied to 1.18wmf1, please consider tagging 1.18

Status & tagging log