r100056 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r100055‎ | r100056 | r100057 >
Date:17:42, 17 October 2011
Author:preilly
Status:ok (Comments)
Tags:
Comment:
part of the fix for bug 31773 - mobile view has invalid html structure
Modified paths:
  • /trunk/extensions/MobileFrontend/views/layout/_search_webkit.html.php (modified) (history)

Diff [purge]

Index: trunk/extensions/MobileFrontend/views/layout/_search_webkit.html.php
@@ -24,8 +24,8 @@
2525 </form>
2626 </div>
2727 <div class='nav' id='nav'>
28 - <button onClick="javascript:location.href='{$mainPageUrl}';" type="submit" id="homeButton">{$homeButton}</button>
29 - <button onClick="javascript:location.href='{$randomPageUrl}';" type="submit" id="randomButton">{$randomButton}</button>
 28+ <button onclick="javascript:location.href='{$mainPageUrl}';" type="submit" id="homeButton">{$homeButton}</button>
 29+ <button onclick="javascript:location.href='{$randomPageUrl}';" type="submit" id="randomButton">{$randomButton}</button>
3030 </div>
3131 </div>
3232 EOD;

Follow-up revisions

RevisionCommit summaryAuthorDate
r100057part of the fix for bug 31773 - mobile view has invalid html structurepreilly17:48, 17 October 2011
r100058mft r100056 r100057preilly17:50, 17 October 2011
r100059part of the fix for bug 31773 - mobile view has invalid html structurepreilly17:53, 17 October 2011
r100062part of the fix for bug 31773 - mobile view has invalid html structurepreilly18:03, 17 October 2011
r100065part of the fix for bug 31773 - mobile view has invalid html structurepreilly18:08, 17 October 2011

Comments

#Comment by G.Hagedorn (talk | contribs)   11:14, 18 October 2011

applied to 1.18wmf1, please consider tagging 1.18, unless reverted in follow-up

Status & tagging log