r99230 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r99229‎ | r99230 | r99231 >
Date:18:48, 7 October 2011
Author:btongminh
Status:ok
Tags:
Comment:
(bug 31487) Don't specify -auto-orient, but specify image rotations ourselves
Modified paths:
  • /trunk/phase3/includes/media/Bitmap.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/media/Bitmap.php
@@ -318,7 +318,8 @@
319319 ( $params['comment'] !== ''
320320 ? " -set comment " . wfEscapeShellArg( $this->escapeMagickProperty( $params['comment'] ) )
321321 : '' ) .
322 - " -depth 8 $sharpen -auto-orient" .
 322+ " -depth 8 $sharpen " .
 323+ " -rotate -$rotation " .
323324 " {$animation_post} " .
324325 wfEscapeShellArg( $this->escapeMagickOutput( $params['dstPath'] ) ) . " 2>&1";
325326

Sign-offs

UserFlagDate
Brion VIBBERinspected22:23, 7 October 2011
Brion VIBBERtested22:23, 7 October 2011

Follow-up revisions

RevisionCommit summaryAuthorDate
r99273MFT r99230: EXIF rotation fix for files where the thumbnail had different ori...brion21:56, 7 October 2011
r99274MFT r99230: EXIF rotation fix for files where the thumbnail had different ori...brion21:57, 7 October 2011

Status & tagging log