r99274 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r99273‎ | r99274 | r99275 >
Date:21:57, 7 October 2011
Author:brion
Status:ok
Tags:
Comment:
MFT r99230: EXIF rotation fix for files where the thumbnail had different orientation from the main image

ImageMagick's auto rotation was picking the wrong one; using explicit rotation instead.
Modified paths:
  • /branches/wmf/1.18wmf1/includes/media/Bitmap.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.18wmf1/includes/media/Bitmap.php
——@@ -318,7 +318,8 @@
319319 ( $params['comment'] !== ''
320320 ? " -set comment " . wfEscapeShellArg( $this->escapeMagickProperty( $params['comment'] ) )
321321 : '' ) .
322 - " -depth 8 $sharpen -auto-orient" .
 322+ " -depth 8 $sharpen " .
 323+ " -rotate -$rotation " .
323324 " {$animation_post} " .
324325 wfEscapeShellArg( $this->escapeMagickOutput( $params['dstPath'] ) ) . " 2>&1";
325326

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r99230(bug 31487) Don't specify -auto-orient, but specify image rotations ourselvesbtongminh18:48, 7 October 2011

Status & tagging log