r99273 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r99272‎ | r99273 | r99274 >
Date:21:56, 7 October 2011
Author:brion
Status:ok
Tags:
Comment:
MFT r99230: EXIF rotation fix for files where the thumbnail had different orientation from the main image

ImageMagick's auto rotation was picking the wrong one; using explicit rotation instead.
Modified paths:
  • /branches/REL1_18/phase3/includes/media/Bitmap.php (modified) (history)

Diff [purge]

Index: branches/REL1_18/phase3/includes/media/Bitmap.php
——@@ -325,7 +325,8 @@
326326 ( $params['comment'] !== ''
327327 ? " -set comment " . wfEscapeShellArg( $this->escapeMagickProperty( $params['comment'] ) )
328328 : '' ) .
329 - " -depth 8 $sharpen -auto-orient" .
 329+ " -depth 8 $sharpen " .
 330+ " -rotate -$rotation " .
330331 " {$animation_post} " .
331332 wfEscapeShellArg( $this->escapeMagickOutput( $params['dstPath'] ) ) . " 2>&1";
332333

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r99230(bug 31487) Don't specify -auto-orient, but specify image rotations ourselvesbtongminh18:48, 7 October 2011

Status & tagging log