r99162 MediaWiki - Code Review archive

Repository:	MediaWiki
Revision:	< r99161‎ \| r99162 \| r99163 >
Date:	22:59, 6 October 2011
Author:	awjrichards
Status:	ok (Comments)
Tags:
Comment:	Removing no longer needed jquery files now that we're using 1.17; Adding separate resources file for defining rapidhtml resrouces for resource loader; removed inline jquery from Form.php and TwoStepTwoColumn.php; moved placeholder js as well as globalcollect_test js into their own files
Modified paths:	/trunk/extensions/DonationInterface/payflowpro_gateway/form_placeholders.js (added) (history) /trunk/extensions/DonationInterface/payflowpro_gateway/forms/Form.php (modified) (history) /trunk/extensions/DonationInterface/payflowpro_gateway/forms/RapidHtml.php (modified) (history) /trunk/extensions/DonationInterface/payflowpro_gateway/forms/TwoStepTwoColumn.php (modified) (history) /trunk/extensions/DonationInterface/payflowpro_gateway/forms/rapidhtml/RapidHtmlResources.php (added) (history) /trunk/extensions/DonationInterface/payflowpro_gateway/forms/rapidhtml/html/globalcollect_test_2.html (modified) (history) /trunk/extensions/DonationInterface/payflowpro_gateway/forms/rapidhtml/js/globalcollect_test_2.js (added) (history) /trunk/extensions/DonationInterface/payflowpro_gateway/forms/rapidhtml/js/jquery.client.js (deleted) (history) /trunk/extensions/DonationInterface/payflowpro_gateway/forms/rapidhtml/js/jquery.js (deleted) (history) /trunk/extensions/DonationInterface/payflowpro_gateway/forms/rapidhtml/js/jquery.ui.accordion.js (deleted) (history) /trunk/extensions/DonationInterface/payflowpro_gateway/forms/rapidhtml/js/jquery.ui.button.js (deleted) (history) /trunk/extensions/DonationInterface/payflowpro_gateway/forms/rapidhtml/js/jquery.ui.core.js (deleted) (history) /trunk/extensions/DonationInterface/payflowpro_gateway/forms/rapidhtml/js/jquery.ui.dialog.js (deleted) (history) /trunk/extensions/DonationInterface/payflowpro_gateway/forms/rapidhtml/js/jquery.ui.draggable.js (deleted) (history) /trunk/extensions/DonationInterface/payflowpro_gateway/forms/rapidhtml/js/jquery.ui.min.js (deleted) (history) /trunk/extensions/DonationInterface/payflowpro_gateway/forms/rapidhtml/js/jquery.ui.mouse.js (deleted) (history) /trunk/extensions/DonationInterface/payflowpro_gateway/forms/rapidhtml/js/jquery.ui.position.js (deleted) (history) /trunk/extensions/DonationInterface/payflowpro_gateway/forms/rapidhtml/js/jquery.ui.resizable.js (deleted) (history) /trunk/extensions/DonationInterface/payflowpro_gateway/forms/rapidhtml/js/jquery.ui.widget.js (deleted) (history) /trunk/extensions/DonationInterface/payflowpro_gateway/forms/rapidhtml/js/webitects_2_3step.js (added) (history) /trunk/extensions/DonationInterface/payflowpro_gateway/payflowpro_gateway.php (modified) (history)

Diff [purge]

The diff is too large to display.

Follow-up revisions

Revision	Commit summary	Author	Date
r100238	Merging the fundraising branch of DonationInterface back into trunk....	khorn	16:57, 19 October 2011

Comments

#Comment by Khorn (WMF) (talk | contribs) 23:40, 6 October 2011

I have but one comment: We'll need to do an additional round of search-and-destroy to make sure all the new globals are handled properly when we merge the fundraiser dev branch back in with this bad boy, or RapidHTML won't be universally available to all the gateways. Clearly that won't stop anything from working in trunk, though. :)

Status & tagging log

23:40, 6 October 2011 Khorn (WMF) (talk | contribs) changed the status of r99162 [removed: new added: ok]