r99161 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r99160‎ | r99161 | r99162 >
Date:22:57, 6 October 2011
Author:aaron
Status:ok
Tags:
Comment:
Don't add 'autoblock disabled' flag for IP range blocks
Modified paths:
  • /trunk/phase3/includes/specials/SpecialBlock.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialBlock.php
@@ -826,7 +826,7 @@
827827 * Return a comma-delimited list of "flags" to be passed to the log
828828 * reader for this block, to provide more information in the logs
829829 * @param $data Array from HTMLForm data
830 - * @param $type Block::TYPE_ constant
 830+ * @param $type Block::TYPE_ constant (USER, RANGE, or IP)
831831 * @return array
832832 */
833833 protected static function blockLogFlags( array $data, $type ) {
@@ -845,7 +845,7 @@
846846 }
847847
848848 # Same as anononly, this is not displayed when blocking an IP address
849 - if( !$data['AutoBlock'] && $type != Block::TYPE_IP ){
 849+ if( !$data['AutoBlock'] && $type == Block::TYPE_USER ){
850850 // For grepping: message block-log-flags-noautoblock
851851 $flags[] = 'noautoblock';
852852 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r99163MFT r99161 "Don't add 'autoblock disabled' flag for IP range blocks"aaron22:59, 6 October 2011

Status & tagging log