r99159 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r99158‎ | r99159 | r99160 >
Date:22:40, 6 October 2011
Author:aaron
Status:ok (Comments)
Tags:
Comment:
Removed "cancel" link. Needs work to be non-confusing and isn't needed due to "de-advertise" link.
Modified paths:
  • /branches/wmf/1.18wmf1/extensions/FlaggedRevs/presentation/RevisionReviewFormUI.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.18wmf1/extensions/FlaggedRevs/presentation/RevisionReviewFormUI.php
——@@ -189,7 +189,7 @@
190190 # Add the submit buttons
191191 $form .= self::submitButtons( $rejectId, $frev, (bool)$disabled, $reviewIncludes );
192192 # Add "cancel" link
193 - $form .= Linker::link( $article->getTitle(), wfMsg( 'revreview-cancel' ) );
 193+ #$form .= Linker::link( $article->getTitle(), wfMsg( 'revreview-cancel' ) );
194194
195195 # Show stability log if there is anything interesting...
196196 if ( $article->isPageLocked() ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r99182Remove confusing "Cancel" button from the diff page altogether....saper01:31, 7 October 2011
r100668LQT MFT r92706...reedy00:14, 25 October 2011

Comments

#Comment by Leinad (talk | contribs)   01:10, 7 October 2011

Hmmm - is it intentional that this revision is not copied to trunk?

#Comment by Aaron Schulz (talk | contribs)   01:38, 7 October 2011

Yes, I was going to look at it later to see what to do. Keeping it removed makes the most sense (and happened in r99182).

Status & tagging log