r99182 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r99181‎ | r99182 | r99183 >
Date:01:31, 7 October 2011
Author:saper
Status:ok
Tags:
Comment:
Remove confusing "Cancel" button from the diff page altogether.
i18n: Remove no longer necesssary 'revreview-cancel' message.
Modified paths:
  • /trunk/extensions/FlaggedRevs/presentation/RevisionReviewFormUI.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/presentation/language/RevisionReview.i18n.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/presentation/language/RevisionReview.i18n.php
@@ -52,7 +52,6 @@
5353 See the [[Special:Unreviewedpages|list of unreviewed pages]].',
5454 'revreview-stable1' => 'You may want to view [{{fullurl:$1|stableid=$2}} this flagged version] and see if it is now the [{{fullurl:$1|stable=1}} stable version] of this page.',
5555 'revreview-stable2' => 'You may want to view the [{{fullurl:$1|stable=1}} stable version] of this page.',
56 - 'revreview-cancel' => 'Cancel',
5756 'revreview-submit' => 'Submit',
5857 'revreview-submitting' => 'Submitting...',
5958 'revreview-submit-review' => 'Accept revision',
@@ -189,8 +188,6 @@
190189 * $2 Number, revision ID just reviewed',
191190 'revreview-stable2' => '{{Flagged Revs}}
192191 Shown after de-accepting a revision of a page.',
193 - 'revreview-cancel' => '{{Identical|Cancel}}
194 -Shown on review form.',
195192 'revreview-submit' => '{{Flagged Revs-small}}
196193 The text on the submit button in the form used to review pages.
197194
@@ -412,7 +409,6 @@
413410 انظر [[Special:Unreviewedpages|قائمة الصفحات غير المراجعة]].',
414411 'revreview-stable1' => 'ربما ترغب في رؤية [{{fullurl:$1|stableid=$2}} هذه النسخة المعلمة] لترى ما إذا كانت [{{fullurl:$1|stable=1}} النسخة المنشورة] لهذه الصفحة.',
415412 'revreview-stable2' => 'قد ترغب في مشاهدة [{{fullurl:$1|stable=1}} النسخة المستقرة] لهذه الصفحة.',
416 - 'revreview-cancel' => 'إلغاء',
417413 'revreview-submit' => 'أرسل',
418414 'revreview-submitting' => 'يرسل...',
419415 'revreview-submit-review' => 'اقبل المراجعة',
@@ -678,7 +674,6 @@
679675 Глядзіце [[Special:Unreviewedpages|сьпіс нерэцэнзаваных старонак]].',
680676 'revreview-stable1' => 'Верагодна, Вы жадаеце праглядзець [{{fullurl:$1|stableid=$2}} гэтую пазначаную вэрсію] і праверыць, ці зьяўляецца яна [{{fullurl:$1|stable=1}} апублікаванай вэрсіяй] гэтай старонкі.',
681677 'revreview-stable2' => 'Верагодна, Вы жадаеце праглядзець [{{fullurl:$1|stable=1}} апублікаваную вэрсію] гэтай старонкі.',
682 - 'revreview-cancel' => 'Скасаваць',
683678 'revreview-submit' => 'Даслаць',
684679 'revreview-submitting' => 'Адпраўка…',
685680 'revreview-submit-review' => 'Зацьвердзіць вэрсію',
@@ -816,7 +811,6 @@
817812 Gwelet [[Special:Unreviewedpages|roll ar pajennoù nann-adlennet]].',
818813 'revreview-stable1' => "Marteze hoc'h eus c'hoant gwelet [{{fullurl:$1|stableid=$2}} ar stumm merket] a-benn gouzout ma 'z eo bremañ [{{fullurl:$1|stable=1}} ar stumm embannet] eus ar bajenn-mañ.",
819814 'revreview-stable2' => "Marteze hoc'h eus c'hoant gwelet [{{fullurl:$1|stable=1}} ar stumm embannet] eus ar bajenn-mañ.",
820 - 'revreview-cancel' => 'Nullañ',
821815 'revreview-submit' => 'Kas',
822816 'revreview-submitting' => 'O kas...',
823817 'revreview-submit-review' => 'Aprouiñ ar stumm',
@@ -1148,7 +1142,6 @@
11491143 Siehe die [[Special:Unreviewedpages|Liste unmarkierter Versionen]].',
11501144 'revreview-stable1' => 'Vielleicht möchtest du [{{fullurl:$1|stableid=$2}} die markierte Version] aufrufen, um zu sehen, ob es nunmehr die [{{fullurl:$1|stable=1}} stabile Version] dieser Seite ist?',
11511145 'revreview-stable2' => 'Vielleicht möchtest du die [{{fullurl:$1|stable=1}} stabile Version] dieser Seite sehen?',
1152 - 'revreview-cancel' => 'Abbrechen',
11531146 'revreview-submit' => 'Speichern',
11541147 'revreview-submitting' => 'Übertragung …',
11551148 'revreview-submit-review' => 'Markiere Version',
@@ -1853,7 +1846,6 @@
18541847 Voir la [[Special:Unreviewedpages|liste des pages non relues]].",
18551848 'revreview-stable1' => 'Vous souhaitez peut-être consulter [{{fullurl:$1|stableid=$2}} cette version marquée] pour voir si c’est maintenant la [{{fullurl:$1|stable=1}} version publiée] de cette page.',
18561849 'revreview-stable2' => 'Vous souhaitez peut-être consulter [{{fullurl:$1|stable=1}} la version publiée] de cette page.',
1857 - 'revreview-cancel' => 'Annuler',
18581850 'revreview-submit' => 'Soumettre',
18591851 'revreview-submitting' => 'Soumission…',
18601852 'revreview-submit-review' => 'Accepter la version',
@@ -1937,7 +1929,6 @@
19381930 Vêde la [[Special:Unreviewedpages|lista de les pâges pas revues]].',
19391931 'revreview-stable1' => 'Vos souhètâd pôt-étre vêre ceta [{{fullurl:$1|stableid=$2}} vèrsion marcâ] por vêre s’o est ora la [{{fullurl:$1|stable=1}} vèrsion stâbla] de cela pâge.',
19401932 'revreview-stable2' => 'Vos souhètâd pôt-étre vêre la [{{fullurl:$1|stable=1}} vèrsion stâbla] de ceta pâge.',
1941 - 'revreview-cancel' => 'Anular',
19421933 'revreview-submit' => 'Sometre',
19431934 'revreview-submitting' => 'Somission...',
19441935 'revreview-submit-review' => 'Aprovar la vèrsion',
@@ -2035,7 +2026,6 @@
20362027 Vexa a [[Special:Unreviewedpages|lista de páxinas sen revisar]].',
20372028 'revreview-stable1' => 'Pode que queira ver [{{fullurl:$1|stableid=$2}} esta versión analizada] para comprobar se agora é [{{fullurl:$1|stable=1}} a versión publicada] desta páxina.',
20382029 'revreview-stable2' => 'Quizais queira ver a [{{fullurl:$1|stable=1}} versión publicada] desta páxina.',
2039 - 'revreview-cancel' => 'Cancelar',
20402030 'revreview-submit' => 'Enviar',
20412031 'revreview-submitting' => 'Enviando...',
20422032 'revreview-submit-review' => 'Aprobar a revisión',
@@ -2215,7 +2205,6 @@
22162206 ראו את [[Special:Unreviewedpages|רשימת הדפים שלא נסקרו]].',
22172207 'revreview-stable1' => 'ייתכן שתרצו לצפות ב[{{fullurl:$1|stableid=$2}} גרסה מסומנת זו] ולראות האם היא עכשיו [{{fullurl:$1|stable=1}} הגרסה היציבה] של הדף הזה.',
22182208 'revreview-stable2' => 'ייתכן שתרצו לצפות ב[{{fullurl:$1|stable=1}} גרסה היציבה] של הדף הזה.',
2219 - 'revreview-cancel' => 'ביטול',
22202209 'revreview-submit' => 'שליחה',
22212210 'revreview-submitting' => 'נשלח...',
22222211 'revreview-submit-review' => 'קבלת הגרסה',
@@ -2403,7 +2392,6 @@
24042393 Hlej [[Special:Unreviewedpages|za lisćinu njepřepruwowanych stronow]].',
24052394 'revreview-stable1' => 'Snano chceš sej [{{fullurl:$1|stableid=$2}} tutu woznamjenjenu wersiju] wobhladać a widźeć, hač je wona nětko [{{fullurl:$1|stable=1}} wozjewjena wersija] tuteje strony.',
24062395 'revreview-stable2' => 'Snano chceš sej [{{fullurl:$1|stable=1}} wozjewjenu wersiju] tuteje strony wobhladać.',
2407 - 'revreview-cancel' => 'Přetorhnyć',
24082396 'revreview-submit' => 'Wotpósłać',
24092397 'revreview-submitting' => 'Sćele so...',
24102398 'revreview-submit-review' => 'Wersiju akceptować',
@@ -2559,7 +2547,6 @@
25602548 Vide le [[Special:Unreviewedpages|lista de paginas non revidite]].',
25612549 'revreview-stable1' => 'Es suggerite vider [{{fullurl:$1|stableid=$2}} iste version marcate] pro determinar si illo es ora le [{{fullurl:$1|stable=1}} version publicate] de iste pagina.',
25622550 'revreview-stable2' => 'Tu pote vider le [{{fullurl:$1|stable=1}} version publicate] de iste pagina.',
2563 - 'revreview-cancel' => 'Cancellar',
25642551 'revreview-submit' => 'Submitter',
25652552 'revreview-submitting' => 'Invio in curso…',
25662553 'revreview-submit-review' => 'Acceptar version',
@@ -3143,7 +3130,6 @@
31443131 Kuckt d'[[Special:Unreviewedpages|Lëscht vun den net nogekuckte Sàiten]].",
31453132 'revreview-stable1' => 'Dir wëllt eventuel [{{fullurl:$1|stableid=$2}} dës markéiert Versioun] gesinn a kucken ob et elo déi [{{fullurl:$1|stable=1}} publizéiert Versioun] vun dëser Säit ass.',
31463133 'revreview-stable2' => 'Dir wëllt vläicht déi [{{fullurl:$1|stable=1}} publizéiert Versioun] vun dëser Säit gesinn.',
3147 - 'revreview-cancel' => 'Ofbriechen',
31483134 'revreview-submit' => 'Späicheren',
31493135 'revreview-submitting' => 'Iwwerdroen …',
31503136 'revreview-submit-review' => 'Versioun akzeptéieren',
@@ -3221,7 +3207,6 @@
32223208 'revreview-main' => "De mós 'n specifieke versie van 'n pagina keze die se wils controlere.
32233209
32243210 Zuuch de [[Special:Unreviewedpages|lies mit ongecontroleerde pagina's]].",
3225 - 'revreview-cancel' => 'Braek aaf',
32263211 'revreview-submit' => 'Slaon óp',
32273212 'revreview-submitting' => 'Ópslaondje...',
32283213 'revreview-submit-review' => 'Käör good',
@@ -3303,7 +3288,6 @@
33043289 Погледајте го [[Special:Unreviewedpages|списокот на неоценети страници]].',
33053290 'revreview-stable1' => 'Препорачуваме да ја погледате [{{fullurl:$1|stableid=$2}} оваа означена верзија] и да проверите дали таа сега е [{{fullurl:$1|stable=1}} објавената верзија] на оваа страница.',
33063291 'revreview-stable2' => 'Ви препорачуваме да ја погледате [{{fullurl:$1|stable=1}} објавената верзија] на оваа страница.',
3307 - 'revreview-cancel' => 'Откажи',
33083292 'revreview-submit' => 'Поднеси',
33093293 'revreview-submitting' => 'Поднесувам ...',
33103294 'revreview-submit-review' => 'Прифати',
@@ -3388,7 +3372,6 @@
33893373 [[Special:Unreviewedpages|സംശോധനം ചെയ്യാത്ത താളുകളുടെ പട്ടിക]] കാണുക.',
33903374 'revreview-stable1' => '[{{fullurl:$1|stableid=$2}} പതാക ചേർത്ത ഈ പതിപ്പ്] ആയിരിക്കാം താങ്കൾക്ക് കാണേണ്ടത് ഒപ്പം അത് ഇപ്പോൾ [{{fullurl:$1|stable=1}} പ്രസിദ്ധീകരിക്കപ്പെട്ട പതിപ്പ്] ആയോ എന്നും കാണുക.',
33913375 'revreview-stable2' => 'ഈ താളിന്റെ [{{fullurl:$1|stable=1}} പ്രസിദ്ധീകരിക്കപ്പെട്ട പതിപ്പ്] താങ്കൾക്ക് കാണാവുന്നതാണ്.',
3392 - 'revreview-cancel' => 'റദ്ദാക്കുക',
33933376 'revreview-submit' => 'സമർപ്പിക്കുക',
33943377 'revreview-submitting' => 'സമർപ്പിക്കുന്നു...',
33953378 'revreview-submit-review' => 'നാൾപ്പതിപ്പ് അംഗീകരിക്കുക',
@@ -3503,7 +3486,6 @@
35043487 Sila lihat [[Special:Unreviewedpages|senarai laman yang belum diperiksa]].',
35053488 'revreview-stable1' => 'Anda boleh melihat [{{fullurl:$1|stableid=$2}} versi bertanda ini] dan melihat sama ada ia sekarang [{{fullurl:$1|stable=1}} versi stabil] bagi laman ini.',
35063489 'revreview-stable2' => 'Mungkin anda ingin melihat [{{fullurl:$1|stable=1}} versi stabil] laman ini.',
3507 - 'revreview-cancel' => 'Batalkan',
35083490 'revreview-submit' => 'Hantar',
35093491 'revreview-submitting' => 'Sedang menyerahkan...',
35103492 'revreview-submit-review' => 'Terima semakan',
@@ -3597,7 +3579,6 @@
35983580 Zie de [[Special:Unreviewedpages|lijst met ongecontroleerde pagina's]].",
35993581 'revreview-stable1' => 'U kunt van deze pagina [{{fullurl:$1|stableid=$2}} deze gecontroleerde versie] bekijken om te beoordelen of dit nu de [{{fullurl:$1|stable=1}} gepubliceerde versie] is.',
36003582 'revreview-stable2' => 'Wellicht wilt u de [{{fullurl:$1|stable=1}} gepubliceerde versie] van deze pagina bekijken.',
3601 - 'revreview-cancel' => 'Annuleren',
36023583 'revreview-submit' => 'Opslaan',
36033584 'revreview-submitting' => 'Bezig met opslaan…',
36043585 'revreview-submit-review' => 'Versie accepteren',
@@ -3831,7 +3812,6 @@
38323813 Zobacz [[Special:Unreviewedpages|listę nieprzejrzanych stron]].',
38333814 'revreview-stable1' => 'Możesz zobaczyć [{{fullurl:$1|stableid=$2}} wersję oznaczoną] i sprawdzić, czy jest ona [{{fullurl:$1|stable=1}} wersją zweryfikowaną] tej strony.',
38343815 'revreview-stable2' => 'Możesz zobaczyć [{{fullurl:$1|stable=1}} wersję zweryfikowaną] tej strony.',
3835 - 'revreview-cancel' => 'Anuluj',
38363816 'revreview-submit' => 'Oznacz wersję',
38373817 'revreview-submitting' => 'Zapisywanie...',
38383818 'revreview-submit-review' => 'Zaakceptuj wersję',
@@ -4310,7 +4290,6 @@
43114291 См. [[Special:Unreviewedpages|список непроверенных страниц]].',
43124292 'revreview-stable1' => 'Возможно, вы хотите просмотреть [{{fullurl:$1|stableid=$2}} эту отмеченную версию] или [{{fullurl:$1|stable=1}} опубликованную версию] этой страницы, если такая существует.',
43134293 'revreview-stable2' => 'Вы можете просмотреть [{{fullurl:$1|stable=1}} опубликованную версию] этой страницы.',
4314 - 'revreview-cancel' => 'Отмена',
43154294 'revreview-submit' => 'Отправить',
43164295 'revreview-submitting' => 'Отправка…',
43174296 'revreview-submit-review' => 'Подтвердить версию',
@@ -4613,7 +4592,6 @@
46144593 Oglejte si [[Special:Unreviewedpages|seznam nepregledanih strani]].',
46154594 'revreview-stable1' => 'Morda si želite ogledati [{{fullurl:$1|stableid=$2}} to označeno različico] in videti, če je zdaj [{{fullurl:$1|stable=1}} ustaljena različica] strani.',
46164595 'revreview-stable2' => 'Morda si želite ogledati [{{fullurl:$1|stable=1}} ustaljeno različico] strani.',
4617 - 'revreview-cancel' => 'Prekliči',
46184596 'revreview-submit' => 'Potrdi',
46194597 'revreview-submitting' => 'Potrjevanje ...',
46204598 'revreview-submit-review' => 'Sprejmi redakcijo',
@@ -5119,7 +5097,6 @@
51205098 [[Special:Unreviewedpages|İncelenmemiş sayfalar listesine]] göz atın.',
51215099 'revreview-stable1' => '[{{fullurl:$1|stableid=$2}} Bu bayraklanmış sürümü] görerek bu sayfanın [{{fullurl:$1|stable=1}} kararlı sürümü] olup olmadığını görmek isteyebilirsiniz.',
51225100 'revreview-stable2' => 'Bu sayfanın [{{fullurl:$1|stable=1}} kararlı sürümünü] görmek isteyebilirsiniz.',
5123 - 'revreview-cancel' => 'İptal',
51245101 'revreview-submit' => 'Gönder',
51255102 'revreview-submitting' => 'Gönderiliyor...',
51265103 'revreview-submit-review' => 'Revizyonu kabul et',
@@ -5374,7 +5351,6 @@
53755352 Mời xem [[Special:Unreviewedpages|danh sách các trang chưa được duyệt]].',
53765353 'revreview-stable1' => 'Bạn có thể muốn xem [{{fullurl:$1|stableid=$2}} phiên bản có cờ này] để xem nó mới có phải là [{{fullurl:$1|stable=1}} phiên bản ổn định] của trang này hay chưa.',
53775354 'revreview-stable2' => 'Bạn có thể muốn xem [{{fullurl:$1|stable=1}} phiên bản ổn định] của trang này.',
5378 - 'revreview-cancel' => 'Hủy bỏ',
53795355 'revreview-submit' => 'Đăng bản duyệt',
53805356 'revreview-submitting' => 'Đang gửi thông tin…',
53815357 'revreview-submit-review' => 'Chấp nhận phiên bản',
@@ -5511,7 +5487,6 @@
55125488 参见[[Special:Unreviewedpages|未复审页面列表]]。',
55135489 'revreview-stable1' => '您可能想要查看[{{fullurl:$1|stableid=$2}} 此已标记的版本],并检查现在是否已有该页面的[{{fullurl:$1|stable=1}} 稳定版本]。',
55145490 'revreview-stable2' => '你可能想要查看该页面的[{{fullurl:$1|stable=1}} 稳定版本]。',
5515 - 'revreview-cancel' => '取消',
55165491 'revreview-submit' => '提交',
55175492 'revreview-submitting' => '提交中……',
55185493 'revreview-submit-review' => '接受修订',
Index: trunk/extensions/FlaggedRevs/presentation/RevisionReviewFormUI.php
@@ -188,9 +188,6 @@
189189 # Add the submit buttons...
190190 $rejectId = $this->rejectRefRevId(); // determine if there will be reject button
191191 $form .= self::submitButtons( $rejectId, $frev, (bool)$disabled, $reviewIncludes );
192 - if ( $this->request->getVal( 'diff' ) ) {
193 - $form .= Linker::link( $this->article->getTitle(), wfMsg( 'revreview-cancel' ) );
194 - }
195192
196193 # Show stability log if there is anything interesting...
197194 if ( $article->isPageLocked() ) {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r99159Removed "cancel" link. Needs work to be non-confusing and isn't needed due to...aaron22:40, 6 October 2011

Status & tagging log