r99158 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r99157‎ | r99158 | r99159 >
Date:22:34, 6 October 2011
Author:jeroendedauw
Status:deferred
Tags:
Comment:
require 1.18, doc update
Modified paths:
  • /trunk/extensions/Contest/Contest.php (modified) (history)
  • /trunk/extensions/Contest/Contest.sql (modified) (history)
  • /trunk/extensions/Contest/resources/contest.special.welcome.css (modified) (history)

Diff [purge]

Index: trunk/extensions/Contest/Contest.php
@@ -24,8 +24,8 @@
2525 die( 'Not an entry point.' );
2626 }
2727
28 -if ( version_compare( $wgVersion, '1.17', '<' ) ) {
29 - die( '<b>Error:</b> Contest requires MediaWiki 1.17 or above.' );
 28+if ( version_compare( $wgVersion, '1.18', '<' ) ) {
 29+ die( '<b>Error:</b> Contest requires MediaWiki 1.18 or above.' );
3030 }
3131
3232 define( 'Contest_VERSION', '0.1 alpha' );
Index: trunk/extensions/Contest/resources/contest.special.welcome.css
@@ -135,7 +135,7 @@
136136 right: 0px;
137137 top: 5px;
138138 /* @embed */
139 - background-image: url(images/icon-box.png);
 139+ background-image: url(images/button_arrow.png);
140140 }
141141
142142 /*#mw-codechallenge-dialog*/ #contest-challanges-list a .mw-codechallenge-icon-box img {
@@ -151,7 +151,7 @@
152152 /*#mw-codechallenge-dialog*/ #contest-challanges-list a:hover .mw-codechallenge-icon-box,
153153 /*#mw-codechallenge-dialog*/ #contest-challanges-list a:focus .mw-codechallenge-icon-box {
154154 /* @embed */
155 - background-image: url(images/icon-box-hover.png);
 155+ background-image: url(images/button_arrow_hover.png);
156156 }
157157
158158 /*#mw-codechallenge-dialog*/ #contest-challanges-list a.selected .mw-codechallenge-icon-box {
Index: trunk/extensions/Contest/Contest.sql
@@ -45,11 +45,11 @@
4646 -- Challenges
4747 CREATE TABLE IF NOT EXISTS /*_*/contest_challenges (
4848 challenge_id INT unsigned NOT NULL auto_increment PRIMARY KEY, -- Challenge id
49 - challenge_contest_id INT unsigned NOT NULL,
 49+ challenge_contest_id INT unsigned NOT NULL, -- Foreign key on contests.contest_id
5050
51 - challenge_text TEXT NOT NULL,
52 - challenge_title VARCHAR(255) NOT NULL,
53 - challenge_oneline TEXT NOT NULL
 51+ challenge_text TEXT NOT NULL, -- Full challange description
 52+ challenge_title VARCHAR(255) NOT NULL, -- Title of the challange
 53+ challenge_oneline TEXT NOT NULL -- One line description of the challange
5454 ) /*$wgDBTableOptions*/;
5555
5656 -- Judge votes

Status & tagging log