r98984 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r98983‎ | r98984 | r98985 >
Date:06:45, 5 October 2011
Author:amire80
Status:ok
Tags:
Comment:
Followup to r98839 and r98851 according to Nikerabbit's suggestions: Xml -> Html and some whitespace.
Modified paths:
  • /trunk/phase3/includes/ChangesList.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/ChangesList.php
@@ -215,9 +215,10 @@
216216 if ( $szdiff < 0 ) {
217217 $formattedSizeClass = 'mw-plusminus-neg';
218218 }
219 - return Xml::element($tag,
220 - array('dir' => 'ltr', 'class' => $formattedSizeClass),
221 - "($formattedSize)");
 219+
 220+ return Html::element( $tag,
 221+ array( 'dir' => 'ltr', 'class' => $formattedSizeClass ),
 222+ "($formattedSize)" );
222223 }
223224
224225 /**

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r98839The general fix is setting the directionality of added or removed bytes in re...amire8000:12, 4 October 2011
r98851Followup to r98847. Replacing .= with =amire8007:33, 4 October 2011

Status & tagging log