r98983 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r98982‎ | r98983 | r98984 >
Date:06:32, 5 October 2011
Author:tstarling
Status:ok
Tags:
Comment:
MFT r98982: fix disabled download buttons
Modified paths:
  • /branches/wmf/1.18wmf1/extensions/Collection/js/collection.js (modified) (history)

Diff [purge]

Index: branches/wmf/1.18wmf1/extensions/Collection/js/collection.js
@@ -151,8 +151,8 @@
152152 $('input.order').attr('disabled', 'disabled');
153153 return;
154154 } else {
155 - $('#downloadButton').attr('disabled', '');
156 - $('input.order').attr('disabled', '');
 155+ $('#downloadButton').removeAttr('disabled');
 156+ $('input.order').removeAttr('disabled');
157157 }
158158 if (!$('#saveButton').length) {
159159 return;
@@ -165,14 +165,14 @@
166166 return;
167167 }
168168 } else if (!$('#personalCollTitle').length || $('#communityCollType:checked').val()) {
169 - $('#communityCollTitle').attr('disabled', '');
 169+ $('#communityCollTitle').removeAttr('disabled');
170170 $('#personalCollTitle').attr('disabled', 'disabled');
171171 if (!$.trim($('#communityCollTitle').val())) {
172172 $('#saveButton').attr('disabled', 'disabled');
173173 return;
174174 }
175175 }
176 - $('#saveButton').attr('disabled', '');
 176+ $('#saveButton').removeAttr('disabled');
177177 }
178178
179179 function make_sortable() {
Property changes on: branches/wmf/1.18wmf1/extensions/Collection/js/collection.js
___________________________________________________________________
Added: svn:mergeinfo
180180 Merged /trunk/extensions/Collection/js/collection.js:r94376,98982

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r98982(bug 31360) Use removeAttr('disabled') instead of attr('disabled', ''). Conso...tstarling06:30, 5 October 2011

Status & tagging log