r98847 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r98846‎ | r98847 | r98848 >
Date:03:08, 4 October 2011
Author:amire80
Status:resolved
Tags:
Comment:
Followup to r98839. Removed 'escape' from wfMsgExt (suggested by Nikerabbit); wrote full class names (suggested by Krinkle).
Modified paths:
  • /trunk/phase3/includes/ChangesList.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/ChangesList.php
@@ -196,7 +196,7 @@
197197 $formattedSize = $wgLang->formatNum($szdiff);
198198
199199 if ( !$fastCharDiff[$code] ) {
200 - $formattedSize = wfMsgExt( 'rc-change-size', array( 'parsemag', 'escape' ), $formattedSize );
 200+ $formattedSize = wfMsgExt( 'rc-change-size', array( 'parsemag' ), $formattedSize );
201201 }
202202
203203 if( abs( $szdiff ) > abs( $wgRCChangedSizeThreshold ) ) {
@@ -204,16 +204,16 @@
205205 } else {
206206 $tag = 'span';
207207 }
208 - $formattedSizeClass = 'mw-plusminus-';
 208+
209209 if ( $szdiff === 0 ) {
210 - $formattedSizeClass .= 'null';
 210+ $formattedSizeClass .= 'mw-plusminus-null';
211211 }
212212 if ( $szdiff > 0 ) {
213213 $formattedSize = '+' . $formattedSize;
214 - $formattedSizeClass .= 'pos';
 214+ $formattedSizeClass .= 'mw-plusminus-pos';
215215 }
216216 if ( $szdiff < 0 ) {
217 - $formattedSizeClass .= 'neg';
 217+ $formattedSizeClass .= 'mw-plusminus-neg';
218218 }
219219 return Xml::element($tag,
220220 array('dir' => 'ltr', 'class' => $formattedSizeClass),

Follow-up revisions

RevisionCommit summaryAuthorDate
r98851Followup to r98847. Replacing .= with =amire8007:33, 4 October 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r98839The general fix is setting the directionality of added or removed bytes in re...amire8000:12, 4 October 2011

Status & tagging log