r98851 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r98850‎ | r98851 | r98852 >
Date:07:33, 4 October 2011
Author:amire80
Status:ok
Tags:
Comment:
Followup to r98847. Replacing .= with =
Modified paths:
  • /trunk/phase3/includes/ChangesList.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/ChangesList.php
@@ -206,14 +206,14 @@
207207 }
208208
209209 if ( $szdiff === 0 ) {
210 - $formattedSizeClass .= 'mw-plusminus-null';
 210+ $formattedSizeClass = 'mw-plusminus-null';
211211 }
212212 if ( $szdiff > 0 ) {
213213 $formattedSize = '+' . $formattedSize;
214 - $formattedSizeClass .= 'mw-plusminus-pos';
 214+ $formattedSizeClass = 'mw-plusminus-pos';
215215 }
216216 if ( $szdiff < 0 ) {
217 - $formattedSizeClass .= 'mw-plusminus-neg';
 217+ $formattedSizeClass = 'mw-plusminus-neg';
218218 }
219219 return Xml::element($tag,
220220 array('dir' => 'ltr', 'class' => $formattedSizeClass),

Follow-up revisions

RevisionCommit summaryAuthorDate
r98984Followup to r98839 and r98851 according to Nikerabbit's suggestions: Xml -> H...amire8006:45, 5 October 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r98847Followup to r98839. Removed 'escape' from wfMsgExt (suggested by Nikerabbit);...amire8003:08, 4 October 2011

Status & tagging log