r98939 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r98938‎ | r98939 | r98940 >
Date:22:16, 4 October 2011
Author:siebrand
Status:ok (Comments)
Tags:
Comment:
Follow-up r98894 (introduced in r98797): fix Finnish method names (should have been English).
Modified paths:
  • /trunk/extensions/Translate/tag/SpecialPageTranslation.php (modified) (history)
  • /trunk/extensions/Translate/tag/SpecialPageTranslationDeletePage.php (modified) (history)
  • /trunk/extensions/Translate/tag/SpecialPageTranslationMovePage.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/tag/SpecialPageTranslation.php
——@@ -544,7 +544,7 @@
545545
546546 // Re-generate caches
547547 MessageGroups::clearCache();
548 - MessageIndexReduildJob::newJob()->insert(); // FIXME: MessageIndexReduildJob is undefined
 548+ MessageIndexRebuildJob::newJob()->insert();
549549 return false;
550550 }
551551
Index: trunk/extensions/Translate/tag/SpecialPageTranslationDeletePage.php
——@@ -308,7 +308,7 @@
309309 }
310310
311311 MessageGroups::clearCache();
312 - MessageIndexReduildJob::newJob()->insert(); // FIXME: MessageIndexReduildJob is undefined
 312+ MessageIndexRebuildJob::newJob()->insert();
313313
314314 global $wgOut;
315315 $wgOut->addWikiMsg( 'pt-deletepage-started' );
Index: trunk/extensions/Translate/tag/SpecialPageTranslationMovePage.php
——@@ -389,7 +389,7 @@
390390 }
391391
392392 MessageGroups::clearCache();
393 - MessageIndexReduildJob::newJob()->insert(); // FIXME: MessageIndexReduildJob is undefined
 393+ MessageIndexRebuildJob::newJob()->insert();
394394
395395 global $wgOut;
396396 $wgOut->addWikiMsg( 'pt-movepage-started' );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r98797Rewrote MessageIndexRebuilder to more generic class with different storage ba...nikerabbit19:05, 3 October 2011
r988943 x MessageIndexReduildJob is undefined...reedy20:10, 4 October 2011

Comments

#Comment by Nikerabbit (talk | contribs)   22:21, 4 October 2011

Interesting concept of Finnish :) The word length matches though.

Status & tagging log