r98894 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r98893‎ | r98894 | r98895 >
Date:20:10, 4 October 2011
Author:reedy
Status:ok
Tags:
Comment:
3 x MessageIndexReduildJob is undefined

Added some documentation to SpecialPageTranslationMovePage
Modified paths:
  • /trunk/extensions/Translate/tag/SpecialPageTranslation.php (modified) (history)
  • /trunk/extensions/Translate/tag/SpecialPageTranslationDeletePage.php (modified) (history)
  • /trunk/extensions/Translate/tag/SpecialPageTranslationMovePage.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/tag/SpecialPageTranslation.php
@@ -541,7 +541,7 @@
542542
543543 // Re-generate caches
544544 MessageGroups::clearCache();
545 - MessageIndexReduildJob::newJob()->insert();
 545+ MessageIndexReduildJob::newJob()->insert(); // FIXME: MessageIndexReduildJob is undefined
546546 return false;
547547 }
548548
Index: trunk/extensions/Translate/tag/SpecialPageTranslationDeletePage.php
@@ -297,7 +297,7 @@
298298 }
299299
300300 MessageGroups::clearCache();
301 - MessageIndexReduildJob::newJob()->insert();
 301+ MessageIndexReduildJob::newJob()->insert(); // FIXME: MessageIndexReduildJob is undefined
302302
303303 global $wgOut;
304304 $wgOut->addWikiMsg( 'pt-deletepage-started' );
Index: trunk/extensions/Translate/tag/SpecialPageTranslationMovePage.php
@@ -22,8 +22,13 @@
2323 */
2424 class SpecialPageTranslationMovePage extends UnlistedSpecialPage {
2525 // Basic form parameters both as text and as titles
26 - protected $newText, $newTitle, $oldText, $oldTitle;
 26+ protected $newText, $oldText;
2727
 28+ /**
 29+ * @var Title
 30+ */
 31+ protected $newTitle, $oldTitle;
 32+
2833 // Other form parameters
2934 /**
3035 * 'check' or 'perform'
@@ -48,6 +53,7 @@
4954
5055 /**
5156 * User instance.
 57+ * @var User
5258 */
5359 protected $user;
5460
@@ -185,6 +191,8 @@
186192 /**
187193 * Checks token. Use before real actions happen. Have to use wpEditToken
188194 * for compatibility for SpecialMovepage.php.
 195+ *
 196+ * @return bool
189197 */
190198 protected function checkToken() {
191199 global $wgRequest;
@@ -380,7 +388,7 @@
381389 }
382390
383391 MessageGroups::clearCache();
384 - MessageIndexReduildJob::newJob()->insert();
 392+ MessageIndexReduildJob::newJob()->insert(); // FIXME: MessageIndexReduildJob is undefined
385393
386394 global $wgOut;
387395 $wgOut->addWikiMsg( 'pt-movepage-started' );

Follow-up revisions

RevisionCommit summaryAuthorDate
r98939Follow-up r98894 (introduced in r98797): fix Finnish method names (should hav...siebrand22:16, 4 October 2011

Status & tagging log