r98938 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r98937‎ | r98938 | r98939 >
Date:22:12, 4 October 2011
Author:krinkle
Status:ok
Tags:
Comment:
[RL2] Bring constancy in tooltip messages on Special:Gadgets
* All tooltips have $1 (tooltips of page-related link have the full page name here, tooltips for gadget related links have the gadget id)
* Call Message::plain() instead of implying ::toString (Follows-up r98729)
Modified paths:
  • /branches/RL2/extensions/Gadgets/Gadgets.i18n.php (modified) (history)
  • /branches/RL2/extensions/Gadgets/SpecialGadgets.php (modified) (history)

Diff [purge]

Index: branches/RL2/extensions/Gadgets/Gadgets.i18n.php
@@ -36,7 +36,7 @@
3737 'gadgets-not-found' => 'Gadget "$1" not found.',
3838 'gadgets-nosuchaction' => 'No such action',
3939
40 - // Main page
 40+ // All gadgets overview
4141 'gadgets-pagetext' => "Below is a list of gadgets available on this wiki. Users can enable or disable these through their [[Special:Preferences#mw-prefsection-gadgets|preferences page]].
4242 This overview provides easy access to the gadget defintions and system message pages that define each gadget's description and title.
4343
@@ -58,13 +58,13 @@
5959 'gadgets-gadget-delete' => 'Delete gadget',
6060 'gadgets-gadget-delete-tooltip' => 'Delete this gadget',
6161
62 - // Single gadget page
 62+ // Single gadget view
6363 'gadgets-gadget-title' => 'Gadget "$1"',
6464 'gadgets-prop-default-on' => 'This gadget is enabled for everyone by default.',
6565 'gadgets-prop-hidden-on' => 'This is a hidden gadget.',
6666 'gadgets-prop-shared-on' => 'This gadget is shared.',
6767
68 - // Export page
 68+ // Export
6969 'gadgets-export-title' => 'Exporting gadget "$1"',
7070 'gadgets-export-text' => 'To export this gadget, click on "{{int:gadgets-export-download}}" button, save the downloaded file,
7171 go to Special:Import on destination wiki and upload it. You must have appropriate permissions on the destination wiki ($3) including the right to edit in the {{ns:Gadget}} and {{ns:Gadget_definition}} namespaces.',
@@ -146,29 +146,33 @@
147147
148148 # For Special:Gadgets
149149 'gadgets-title' => '{{Identical|Gadgets}}',
 150+ 'gadgets-nosuchaction' => 'Identical to core:
 151+* {{mw-msg|nosuchaction}}.',
 152+
 153+ // All gadgets view
 154+ 'gadgets-message-edit' => 'Used as linktext for the link to edit the cateogory title, gadget title or gadget description.
 155+
 156+{{Identical|Edit}}',
 157+ 'gadgets-message-edit-tooltip' => '$1 is full page name',
 158+ 'gadgets-desc-edit-tooltip' => '$1 is full page name',
 159+ 'gadgets-desc-add-tooltip' => '$1 is full page name',
 160+ 'gadgets-gadget-permalink-tooltip' => '$1 is the gadget id',
 161+ 'gadgets-gadget-export-tooltip' => '$1 is the gadget id',
 162+ 'gadgets-gadget-modify-tooltip' => '$1 is the gadget id',
 163+ 'gadgets-gadget-delete-tooltip' => '$1 is the gadget id',
 164+
 165+ // Export
150166 'gadgets-export' => 'Used on [[Special:Gadgets]]. This is a verb, not a noun.
151167
152168 {{Identical|Export}}',
153169 'gadgets-export-download' => 'Use the verb for this message. Submit button.
154170
155171 {{Identical|Download}}',
156 - 'gadgets-message-edit' => 'Used as linktext for the link to edit the cateogory title, gadget title or gadget description.
157172
158 -{{Identical|Edit}}',
159 - 'gadgets-message-edit-tooltip' => 'Parameters:
160 -* $1: Page name in the MediaWiki namespace where this message is defined.',
161 - 'gadgets-desc-add' => 'Used as linktext for the link to create gadget description.
162 -
163 -{{Identical|Add}}.',
164 - 'gadgets-desc-add-tooltip' => 'Parameters:
165 -* $1: Page name in the MediaWiki namespace where this message is defined.',
166 - 'gadgets-nosuchaction' => 'Identical to core:
167 -* {{mw-msg|nosuchaction}}.',
 173+ # For the ext.gadgets.gadgetmanager module
168174 'gadgets-gadget-create' => 'Identical to core:
169175 * {{mw-msg|vector-view-create}}
170176 * {{mw-msg|create}}',
171 -
172 - # For the ext.gadgets.gadgetmanager module
173177 'gadgetmanager-comment-modify' => 'Edit summary used when modifying gadget definition pages through AJAX on [[Special:Gadgets]].',
174178 'gadgetmanager-comment-create' => 'Edit summary used when creating gadget definition pages through AJAX on [[Special:Gadgets]].',
175179
Index: branches/RL2/extensions/Gadgets/SpecialGadgets.php
@@ -108,7 +108,7 @@
109109 $this->getTitle( $gadget->getId() ),
110110 wfMessage( 'gadgets-gadget-permalink' )->escaped(),
111111 array(
112 - 'title' => wfMessage( 'gadgets-gadget-permalink-tooltip' )->plain(),
 112+ 'title' => wfMessage( 'gadgets-gadget-permalink-tooltip', $gadget->getId() )->plain(),
113113 'class' => 'mw-gadgets-permalink',
114114 )
115115 );
@@ -117,7 +117,7 @@
118118 $this->getTitle( "{$gadget->getId()}/export" ),
119119 wfMessage( 'gadgets-gadget-export' )->escaped(),
120120 array(
121 - 'title' => wfMessage( 'gadgets-gadget-export-tooltip' )->plain(),
 121+ 'title' => wfMessage( 'gadgets-gadget-export-tooltip', $gadget->getId() )->plain(),
122122 'class' => 'mw-gadgets-export',
123123 )
124124
@@ -131,7 +131,7 @@
132132 $gadgetDefinitionTitle,
133133 wfMessage( 'gadgets-gadget-modify' )->escaped(),
134134 array(
135 - 'title' => wfMessage( 'gadgets-gadget-modify-tooltip' )->plain(),
 135+ 'title' => wfMessage( 'gadgets-gadget-modify-tooltip', $gadget->getId() )->plain(),
136136 'class' => 'mw-gadgets-modify',
137137 ),
138138 array( 'action' => 'edit' )
@@ -143,7 +143,7 @@
144144 $gadgetDefinitionTitle,
145145 wfMessage( 'gadgets-gadget-delete' )->escaped(),
146146 array(
147 - 'title' => wfMessage( 'gadgets-gadget-delete-tooltip' )->plain(),
 147+ 'title' => wfMessage( 'gadgets-gadget-delete-tooltip', $gadget->getId() )->plain(),
148148 'class' => 'mw-gadgets-delete',
149149 ),
150150 array( 'action' => 'delete' )
@@ -159,7 +159,7 @@
160160 $editLink = Linker::link(
161161 $t,
162162 wfMessage( 'gadgets-message-edit' )->escaped(),
163 - array( 'title' => wfMessage( 'gadgets-message-edit-tooltip', $t->getPrefixedText() ) ),
 163+ array( 'title' => wfMessage( 'gadgets-message-edit-tooltip', $t->getPrefixedText() )->plain() ),
164164 array( 'action' => 'edit' )
165165 );
166166 $editTitle = '<span class="mw-gadgets-messagelink">' . $editLink . '</span>';
@@ -170,7 +170,7 @@
171171 $editLink = Linker::link(
172172 $t,
173173 wfMessage( $t->isKnown() ? 'gadgets-desc-edit' : 'gadgets-desc-add' )->escaped(),
174 - array( 'title' => wfMessage( $t->isKnown() ? 'gadgets-desc-edit-tooltip' : 'gadgets-desc-add-tooltip', $t->getPrefixedText() ) ),
 174+ array( 'title' => wfMessage( $t->isKnown() ? 'gadgets-desc-edit-tooltip' : 'gadgets-desc-add-tooltip', $t->getPrefixedText() )->plain() ),
175175 array( 'action' => 'edit' )
176176 );
177177 $editDescription = '<span class="mw-gadgets-messagelink">' . $editLink . '</span>';

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r98729[RL2] Merge gadget manager into SpecialGadgets...krinkle01:26, 3 October 2011

Status & tagging log