r98617 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r98616‎ | r98617 | r98618 >
Date:16:18, 1 October 2011
Author:dasch
Status:resolved (Comments)
Tags:
Comment:
full name of special pages, the same used on page with all special pages (that also adds localistation)
Modified paths:
  • /trunk/extensions/RefreshSpecial/RefreshSpecial.body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/RefreshSpecial/RefreshSpecial.body.php
——@@ -120,7 +120,7 @@
121121 $checked = 'checked="checked"';
122122 $wgOut->addHTML("\t\t\t\t\t<li>
123123 <input type=\"checkbox\" name=\"wpSpecial[]\" value=\"$special\" $checked />
124 - <b>$special</b>
 124+ <b>" . wfMsg($special) . "</b>
125125 </li>\n");
126126 }
127127 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r106451Cleanup to r98617, use getDescription() and add some escaping.demon17:48, 16 December 2011

Comments

#Comment by Nikerabbit (talk | contribs)   16:37, 1 October 2011

You are assuming that all special query pages use that naming convention for messages, which is not always true. Why not use $special->getDescription()?

#Comment by Krinkle (talk | contribs)   23:03, 5 October 2011

Also needs html escaping!

Status & tagging log