r106451 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r106450‎ | r106451 | r106452 >
Date:17:48, 16 December 2011
Author:demon
Status:ok
Tags:
Comment:
Cleanup to r98617, use getDescription() and add some escaping.
Modified paths:
  • /trunk/extensions/RefreshSpecial/RefreshSpecial.body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/RefreshSpecial/RefreshSpecial.body.php
@@ -118,9 +118,10 @@
119119 $checked = '';
120120 if ( $queryPage->isExpensive() ) {
121121 $checked = 'checked="checked"';
 122+ $specialEsc = htmlspecialchars( $special );
122123 $wgOut->addHTML("\t\t\t\t\t<li>
123 - <input type=\"checkbox\" name=\"wpSpecial[]\" value=\"$special\" $checked />
124 - <b>" . wfMsg($special) . "</b>
 124+ <input type=\"checkbox\" name=\"wpSpecial[]\" value=\"$specialEsc\" $checked />
 125+ <b>" . htmlspecialchars( $specialObj->getDescription() ) . "</b>
125126 </li>\n");
126127 }
127128 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r98617full name of special pages, the same used on page with all special pages (tha...dasch16:18, 1 October 2011

Status & tagging log