r98616 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r98615‎ | r98616 | r98617 >
Date:09:02, 1 October 2011
Author:petrb
Status:deferred (Comments)
Tags:
Comment:
it seems that ApiLogin doesn't have example which would need to be updated, so I just updated the way how token looks with +\ anyway ApiLogin.php should have better example which also points on the fact that user needs to use token, now there is only a link to bugzilla
Modified paths:
  • /branches/petrb/phase3/includes/Defines.php (modified) (history)

Diff [purge]

Index: branches/petrb/phase3/includes/Defines.php
——@@ -254,4 +254,4 @@
255255 /**
256256 * Common example strings for api examples
257257 */
258 -define( 'EXAMPLE_TOKEN', 'abcdef123456789ab12ab12cd45ef78' ); //in case that way how token looks change it would save us a lot of work rewriting all examples
 258+define( 'EXAMPLE_TOKEN', 'abcdef123456789ab12ab12cd45ef78%2B%5C' ); //in case that way how token looks change it would save us a lot of work rewriting all examples

Comments

#Comment by Petrb (talk | contribs)   09:06, 1 October 2011

I meant that link which pops out on line 195, it's not anywhere in example of course

Status & tagging log