r97926 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r97925‎ | r97926 | r97927 >
Date:16:50, 23 September 2011
Author:pgehres
Status:ok
Tags:
Comment:
Actually fixing bug fix attempted in r97925.
Modified paths:
  • /trunk/extensions/DonationInterface/payflowpro_gateway/forms/rapidhtml/html/webitects_2_3step.html (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/payflowpro_gateway/forms/rapidhtml/html/webitects_2_3step.html
@@ -274,11 +274,15 @@
275275 if( amountErrorString != ""){
276276 $("#amountErrorMessages").html( amountErrorString );
277277 prevError = true;
 278+ showStep2(); // init the headers
 279+ showStep3();
278280 showStep1(); // should be default, but ensure
279281 }
280282 if( billingErrorString != ""){
281283 $("#billingErrorMessages").html( billingErrorString );
282284 if( !prevError ){
 285+ showStep1(); // init the headers
 286+ showStep3();
283287 showStep2();
284288 prevError = true;
285289 }
@@ -286,8 +290,11 @@
287291 }
288292 if( paymentErrorString != ""){
289293 $("#paymentErrorMessages").html( paymentErrorString );
290 - if( !prevError )
291 - showStep3();
 294+ if( !prevError ){
 295+ showStep1(); // init the headers
 296+ showStep2();
 297+ showStep3();
 298+ }
292299 showAmount( $('input[name="amount"]') ); // lets go ahead and assume there is something to show
293300 }
294301
@@ -350,7 +357,6 @@
351358 showStep2();
352359 });
353360 $("#step3header").click(function(){
354 - showStep2();
355361 showStep3();
356362 });
357363

Follow-up revisions

RevisionCommit summaryAuthorDate
r97927MFT r97923, r97925, r97926awjrichards17:00, 23 September 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r97925Fixing missing step 2 header on error reloadpgehres16:45, 23 September 2011

Status & tagging log