r97923 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r97922‎ | r97923 | r97924 >
Date:16:29, 23 September 2011
Author:pgehres
Status:ok
Tags:fundraising 
Comment:
Fixing relative image path on paypal redirect images. Removed broswer detection and redirection from 2_3step.
Modified paths:
  • /trunk/extensions/DonationInterface/payflowpro_gateway/forms/rapidhtml/html/webitects_1.html (modified) (history)
  • /trunk/extensions/DonationInterface/payflowpro_gateway/forms/rapidhtml/html/webitects_1a.html (modified) (history)
  • /trunk/extensions/DonationInterface/payflowpro_gateway/forms/rapidhtml/html/webitects_2.html (modified) (history)
  • /trunk/extensions/DonationInterface/payflowpro_gateway/forms/rapidhtml/html/webitects_2_3step.html (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/payflowpro_gateway/forms/rapidhtml/html/webitects_2_3step.html
@@ -240,17 +240,6 @@
241241 // ensure all jQuery instances are set to 1.4.2
242242 jQuery = $;
243243 $j = $;
244 -
245 - // This form is radically broken in IE6
246 - // Redirecting them to another page
247 - // TODO: handle this in the banner
248 - if (jQuery.browser.msie && jQuery.browser.version.substr(0,1)<7){
249 - //get the current querystring
250 - var qs = window.location.search.substring(1);
251 - // redirect IE6 people to another form
252 - window.location.replace("https://wikimediafoundation.org/wiki/Special:LandingCheck?language=en&landing_page=L11_ExtraInfo_0902_N&utm_campaign=C_0916_Webitects_US_ie6&utm_source=B_BR_0916_US&country_code=US&referrer=webitects2");
253 - }
254 -
255244
256245 // check for RapidHtml errors and display, if any
257246 var amountErrors = ['#general|escape','#retryMsg|escape','#amount|escape'],
@@ -317,7 +306,7 @@
318307 // set the action to go to PayPal
319308 $('input[name="gateway"]').val("paypal");
320309 $('input[name="PaypalRedirect"]').val("1");
321 - $("#loading").html("<img src='../images/loading.gif' /> Redirecting to PayPal…");
 310+ $("#loading").html("<img src='@script_path/extensions/DonationInterface/payflowpro_gateway/forms/rapidhtml/images/loading-white.gif' /> Redirecting to PayPal…");
322311 document.paypalcontribution.action = "@action";
323312 document.paypalcontribution.submit();
324313 }
Index: trunk/extensions/DonationInterface/payflowpro_gateway/forms/rapidhtml/html/webitects_1.html
@@ -289,7 +289,7 @@
290290 // set the action to go to PayPal
291291 $("input[name=gateway]").val("paypal");
292292 document.paypalcontribution.action = "https://wikimediafoundation.org/wiki/Special:ContributionTracking/en";
293 - $("#loading").html("<img src='../images/loading.gif' /> Redirecting to PayPal…");
 293+ $("#loading").html("<img src='@script_path/extensions/DonationInterface/payflowpro_gateway/forms/rapidhtml/images/loading-green.gif' /> Redirecting to PayPal…");
294294 document.paypalcontribution.submit();
295295 }
296296 });
Index: trunk/extensions/DonationInterface/payflowpro_gateway/forms/rapidhtml/html/webitects_1a.html
@@ -290,7 +290,7 @@
291291 // set the action to go to PayPal
292292 $("input[name=gateway]").val("paypal");
293293 document.paypalcontribution.action = "https://wikimediafoundation.org/wiki/Special:ContributionTracking/en";
294 - $("#loading").html("<img src='../images/loading.gif' /> Redirecting to PayPal…");
 294+ $("#loading").html("<img src='@script_path/extensions/DonationInterface/payflowpro_gateway/forms/rapidhtml/images/loading-green.gif' /> Redirecting to PayPal…");
295295 document.paypalcontribution.submit();
296296 }
297297 });
Index: trunk/extensions/DonationInterface/payflowpro_gateway/forms/rapidhtml/html/webitects_2.html
@@ -293,7 +293,7 @@
294294 // set the action to go to PayPal
295295 $("input[name=gateway]").val("paypal");
296296 document.paypalcontribution.action = "https://wikimediafoundation.org/wiki/Special:ContributionTracking/en";
297 - $("#loading").html("<img src='../images/loading.gif' /> Redirecting to PayPal…");
 297+ $("#loading").html("<img src='@script_path/extensions/DonationInterface/payflowpro_gateway/forms/rapidhtml/images/loading-white.gif' /> Redirecting to PayPal…");
298298 document.paypalcontribution.submit();
299299 }
300300 });

Follow-up revisions

RevisionCommit summaryAuthorDate
r97924MFT r97923awjrichards16:31, 23 September 2011
r97927MFT r97923, r97925, r97926awjrichards17:00, 23 September 2011

Status & tagging log