r97927 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r97926‎ | r97927 | r97928 >
Date:17:00, 23 September 2011
Author:awjrichards
Status:ok
Tags:
Comment:
Modified paths:
  • /branches/fundraising/deployment/DonationInterface/payflowpro_gateway (modified) (history)
  • /branches/fundraising/deployment/DonationInterface/payflowpro_gateway/extras/minfraud/ccfd/CreditCardFraudDetection.php (modified) (history)
  • /branches/fundraising/deployment/DonationInterface/payflowpro_gateway/extras/recaptcha/recaptcha-php/recaptchalib.php (modified) (history)
  • /branches/fundraising/deployment/DonationInterface/payflowpro_gateway/forms (modified) (history)
  • /branches/fundraising/deployment/DonationInterface/payflowpro_gateway/forms/rapidhtml/html/webitects_2_3step.html (modified) (history)
  • /branches/fundraising/deployment/DonationInterface/payflowpro_gateway/payflowpro_gateway.alias.php (modified) (history)
  • /branches/fundraising/deployment/DonationInterface/payflowpro_gateway/payflowpro_gateway.i18n.php (modified) (history)
  • /branches/fundraising/deployment/DonationInterface/payflowpro_gateway/validate_input.js (modified) (history)

Diff [purge]

Property changes on: branches/fundraising/deployment/DonationInterface/payflowpro_gateway/payflowpro_gateway.alias.php
___________________________________________________________________
Modified: svn:mergeinfo
11 Merged /trunk/extensions/DonationInterface/payflowpro_gateway/payflowpro_gateway.alias.php:r97924-97926
Property changes on: branches/fundraising/deployment/DonationInterface/payflowpro_gateway/validate_input.js
___________________________________________________________________
Modified: svn:mergeinfo
22 Merged /trunk/extensions/DonationInterface/payflowpro_gateway/validate_input.js:r97924-97926
Property changes on: branches/fundraising/deployment/DonationInterface/payflowpro_gateway/extras/minfraud/ccfd/CreditCardFraudDetection.php
___________________________________________________________________
Modified: svn:mergeinfo
33 Merged /trunk/extensions/DonationInterface/payflowpro_gateway/extras/minfraud/ccfd/CreditCardFraudDetection.php:r97924-97926
Property changes on: branches/fundraising/deployment/DonationInterface/payflowpro_gateway/extras/recaptcha/recaptcha-php/recaptchalib.php
___________________________________________________________________
Modified: svn:mergeinfo
44 Merged /trunk/extensions/DonationInterface/payflowpro_gateway/extras/recaptcha/recaptcha-php/recaptchalib.php:r97924-97926
Index: branches/fundraising/deployment/DonationInterface/payflowpro_gateway/forms/rapidhtml/html/webitects_2_3step.html
@@ -274,11 +274,15 @@
275275 if( amountErrorString != ""){
276276 $("#amountErrorMessages").html( amountErrorString );
277277 prevError = true;
 278+ showStep2(); // init the headers
 279+ showStep3();
278280 showStep1(); // should be default, but ensure
279281 }
280282 if( billingErrorString != ""){
281283 $("#billingErrorMessages").html( billingErrorString );
282284 if( !prevError ){
 285+ showStep1(); // init the headers
 286+ showStep3();
283287 showStep2();
284288 prevError = true;
285289 }
@@ -286,8 +290,11 @@
287291 }
288292 if( paymentErrorString != ""){
289293 $("#paymentErrorMessages").html( paymentErrorString );
290 - if( !prevError )
291 - showStep3();
 294+ if( !prevError ){
 295+ showStep1(); // init the headers
 296+ showStep2();
 297+ showStep3();
 298+ }
292299 showAmount( $('input[name="amount"]') ); // lets go ahead and assume there is something to show
293300 }
294301
Property changes on: branches/fundraising/deployment/DonationInterface/payflowpro_gateway/forms
___________________________________________________________________
Modified: svn:mergeinfo
295302 Merged /trunk/extensions/DonationInterface/payflowpro_gateway/forms:r97924-97926
Property changes on: branches/fundraising/deployment/DonationInterface/payflowpro_gateway/payflowpro_gateway.i18n.php
___________________________________________________________________
Modified: svn:mergeinfo
296303 Merged /trunk/extensions/DonationInterface/payflowpro_gateway/payflowpro_gateway.i18n.php:r97924-97926
Property changes on: branches/fundraising/deployment/DonationInterface/payflowpro_gateway
___________________________________________________________________
Modified: svn:mergeinfo
297304 Merged /trunk/extensions/DonationInterface/payflowpro_gateway:r97924-97926

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r97923Fixing relative image path on paypal redirect images. Removed broswer detect...pgehres16:29, 23 September 2011
r97925Fixing missing step 2 header on error reloadpgehres16:45, 23 September 2011
r97926Actually fixing bug fix attempted in r97925.pgehres16:50, 23 September 2011

Status & tagging log