r97785 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r97784‎ | r97785 | r97786 >
Date:03:37, 22 September 2011
Author:tstarling
Status:ok
Tags:
Comment:
Removed the redundant wfMkdirParents() call added to BitmapHandler::doTransform() in r79845. This causes problems on Wikimedia due to incorrect NFS access. If a sysadmin misconfigures their thumbnail destination directory, they should get a helpful error message, it shouldn't transparently fall back to client-side scaling and cache the resulting HTML forever.
Modified paths:
  • /trunk/phase3/includes/media/Bitmap.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/media/Bitmap.php
——@@ -223,13 +223,6 @@
224224 } else {
225225 $scaler = 'client';
226226 }
227 -
228 - if ( $scaler != 'client' && $dstPath ) {
229 - if ( !wfMkdirParents( dirname( $dstPath ), null, __METHOD__ ) ) {
230 - # Unable to create a path for the thumbnail
231 - return 'client';
232 - }
233 - }
234227 return $scaler;
235228 }
236229

Follow-up revisions

RevisionCommit summaryAuthorDate
r97787MFT r97785: fix fallback to client-side scaling occurring on 1.18 wikis such ...tstarling03:44, 22 September 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r79845$wgMaxUploadSize may now be set to an array to specify the upload size limit ...btongminh22:12, 7 January 2011

Status & tagging log