r97787 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r97786‎ | r97787 | r97788 >
Date:03:44, 22 September 2011
Author:tstarling
Status:ok
Tags:
Comment:
MFT r97785: fix fallback to client-side scaling occurring on 1.18 wikis such as mediawiki.org
Modified paths:
  • /branches/wmf/1.18wmf1/includes/media/Bitmap.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.18wmf1/includes/media/Bitmap.php
——@@ -223,13 +223,6 @@
224224 } else {
225225 $scaler = 'client';
226226 }
227 -
228 - if ( $scaler != 'client' && $dstPath ) {
229 - if ( !wfMkdirParents( dirname( $dstPath ) ) ) {
230 - # Unable to create a path for the thumbnail
231 - return 'client';
232 - }
233 - }
234227 return $scaler;
235228 }
236229
Property changes on: branches/wmf/1.18wmf1/includes/media/Bitmap.php
___________________________________________________________________
Added: svn:mergeinfo
237230 Merged /branches/new-installer/phase3/includes/media/Bitmap.php:r43664-66004
238231 Merged /branches/wmf-deployment/includes/media/Bitmap.php:r53381
239232 Merged /branches/REL1_15/phase3/includes/media/Bitmap.php:r51646
240233 Merged /branches/sqlite/includes/media/Bitmap.php:r58211-58321
241234 Merged /trunk/phase3/includes/media/Bitmap.php:r92580,92634,92713,92762,92765,92791,92854,92884,92886-92887,92894,92898,92907,92932,92958,93141,93149,93151,93233-93234,93258,93266,93303,93516-93518,93818-93822,93847,93858,93891,93935-93936,94058,94062,94068,94107,94155,94235,94277,94346,94372,94422,94425,94444,94448,94456,94498,94517,94601,94630,94728,94738,94825,94862,94995-94997,95023,95042,95072-95073,95155,95327,95332,95410,95422,95426,95442,95468,95601,95812,97785

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r97785Removed the redundant wfMkdirParents() call added to BitmapHandler::doTransfo...tstarling03:37, 22 September 2011

Status & tagging log