r97784 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r97783‎ | r97784 | r97785 >
Date:03:28, 22 September 2011
Author:aaron
Status:ok (Comments)
Tags:
Comment:
Added back xml::hidden wrapper, used by LQT
Modified paths:
  • /branches/wmf/1.18wmf1/includes/Xml.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.18wmf1/includes/Xml.php
——@@ -451,6 +451,13 @@
452452 }
453453
454454 /**
 455+ * @deprecated Synonymous to Html::hidden()
 456+ */
 457+ public static function hidden( $name, $value, $attribs = array() ) {
 458+ return Html::hidden( $name, $value, $attribs );
 459+ }
 460+
 461+ /**
455462 * Convenience function to build an HTML drop-down list item.
456463 * @param $text String: text for this item
457464 * @param $value String: form submission value; if empty, use text

Comments

#Comment by P858snake (talk | contribs)   09:28, 22 September 2011

Just a note for those looking later: This was so the 1.17wmf branch of LQT could work on 1.18 (since the DB schema changes for it weren't done)

#Comment by G.Hagedorn (talk | contribs)   12:14, 22 September 2011

please tag for 1.18

#Comment by P858snake (talk | contribs)   12:15, 22 September 2011

This isn't need for 1.18, They can run the 1.18 branch of LQT, the reason its not on the wmf cluster is the db schema hasn't been updated yet.

#Comment by G.Hagedorn (talk | contribs)   13:27, 22 September 2011

If WMF plans to revert these changes and also upgrade to LQT 1.18, thus truly testing it, that is fine.

Else I believe most users would prefer to have a tested, working version. We would like to start using LQT, which was impossible in the 1.17 release, and I have doubts how well tested the 1.18 version is. I fear the WMF version may be the only truly tested version of LQT.

#Comment by Reedy (talk | contribs)   13:35, 22 September 2011

This is because for 1.17wmf1 we were still using the version of LQT from 1.16wmf4

For 1.18wmf1, I had it branch from REL1_18, but as now transpired, that was missing some schema updates from September 2010 (months before 1.17wmf1), so hence REL1_18 LQT breaking on the site.

This was then reverted back to the old version (ie from 1.16wmf4), which also doesn't work due to edit.js being missing, per bug 31087

I've fixed the schema patch in r97811 and tagged that for 1.18 backport

When the appropriate operations staff are available later today, I shall speak about getting the necessary index updates done, and the newer version of LQT to be pushed out to WMF sites

Status & tagging log