r97811 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r97810‎ | r97811 | r97812 >
Date:12:33, 22 September 2011
Author:reedy
Status:ok
Tags:
Comment:
Fix ums_conversation.sql patch per changes on r72707

Drop ums_read index, add ums_user_conversation

<pre>
Index: trunk/extensions/LiquidThreads/lqt.sql
===================================================================
--- trunk/extensions/LiquidThreads/lqt.sql (revision 72706)
+++ trunk/extensions/LiquidThreads/lqt.sql (revision 72707)
@@ -57,11 +57,12 @@
CREATE TABLE /*$wgDBprefix*/user_message_state (
ums_user int unsigned NOT NULL,
ums_thread int(8) unsigned NOT NULL,
+ ums_conversation int(8) unsigned NOT NULL DEFAULT 0,
ums_read_timestamp varbinary(14),

PRIMARY KEY (ums_user, ums_thread)
) /*$wgDBTableOptions*/;
-CREATE INDEX ums_user_read ON /*$wgDBprefix*/user_message_state (ums_user,ums_read_timestamp);
+CREATE INDEX ums_user_conversation ON /*$wgDBprefix*/user_message_state (ums_user,ums_conversation);
</pre>
Modified paths:
  • /trunk/extensions/LiquidThreads/schema-changes/ums_conversation.sql (modified) (history)

Diff [purge]

Index: trunk/extensions/LiquidThreads/schema-changes/ums_conversation.sql
@@ -3,7 +3,7 @@
44 ALTER TABLE /*_*/user_message_state ADD COLUMN ums_conversation int(8) unsigned NOT NULL DEFAULT 0;
55
66 CREATE INDEX /*i*/ums_user_conversation ON /*_*/user_message_state (ums_user,ums_conversation);
7 -DROP INDEX /*i*/ums_user_conversation ON /*_*/user_message_state;
 7+DROP INDEX /*i*/ums_read ON /*_*/user_message_state;
88
99 UPDATE /*_*/user_message_state, /*_*/thread
1010 SET /*_*/user_message_state.ums_conversation = if(/*_*/thread.thread_ancestor, /*_*/thread.thread_ancestor, /*_*/thread.thread_id)

Follow-up revisions

RevisionCommit summaryAuthorDate
r97814REL1_18 MFT r97811reedy13:57, 22 September 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r72707More or less rewrote Special:NewMessages. Only user-visible change is that it...werdna10:13, 10 September 2010

Status & tagging log