r97637 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r97636‎ | r97637 | r97638 >
Date:15:58, 20 September 2011
Author:robin
Status:ok
Tags:
Comment:
r97636: ParserCache meant to be committed already too
Modified paths:
  • /trunk/phase3/includes/parser/ParserCache.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/parser/ParserCache.php
@@ -80,7 +80,7 @@
8181 */
8282 function getETag( $article, $popts ) {
8383 return 'W/"' . $this->getParserOutputKey( $article,
84 - $popts->optionsHash( ParserOptions::legacyOptions() ) ) .
 84+ $popts->optionsHash( ParserOptions::legacyOptions(), $article->getTitle() ) ) .
8585 "--" . $article->getTouched() . '"';
8686 }
8787
@@ -130,7 +130,7 @@
131131 $usedOptions = ParserOptions::legacyOptions();
132132 }
133133
134 - return $this->getParserOutputKey( $article, $popts->optionsHash( $usedOptions ) );
 134+ return $this->getParserOutputKey( $article, $popts->optionsHash( $usedOptions, $article->getTitle() ) );
135135 }
136136
137137 /**
@@ -165,7 +165,8 @@
166166 $value = $this->mMemc->get( $parserOutputKey );
167167 if ( self::try116cache && !$value && strpos( $value, '*' ) !== -1 ) {
168168 wfDebug( "New format parser cache miss.\n" );
169 - $parserOutputKey = $this->getParserOutputKey( $article, $popts->optionsHash( ParserOptions::legacyOptions() ) );
 169+ $parserOutputKey = $this->getParserOutputKey( $article,
 170+ $popts->optionsHash( ParserOptions::legacyOptions(), $article->getTitle() ) );
170171 $value = $this->mMemc->get( $parserOutputKey );
171172 }
172173 if ( !$value ) {
@@ -211,7 +212,7 @@
212213 $optionsKey->setContainsOldMagic( $parserOutput->containsOldMagic() );
213214
214215 $parserOutputKey = $this->getParserOutputKey( $article,
215 - $popts->optionsHash( $optionsKey->mUsedOptions ) );
 216+ $popts->optionsHash( $optionsKey->mUsedOptions, $article->getTitle() ) );
216217
217218 // Save the timestamp so that we don't have to load the revision row on view
218219 $parserOutput->mTimestamp = $article->getTimestamp();

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r97636Re-do several things of r96798 in preparation of re-doing the rest (there's a...robin15:55, 20 September 2011

Status & tagging log