r97610 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r97609‎ | r97610 | r97611 >
Date:09:20, 20 September 2011
Author:catrope
Status:ok
Tags:
Comment:
1.18wmf1: MFT r97607, r97608 (ResourceLoader fixes)
Modified paths:
  • /branches/wmf/1.18wmf1/includes/resourceloader/ResourceLoaderContext.php (modified) (history)
  • /branches/wmf/1.18wmf1/resources/mediawiki/mediawiki.js (modified) (history)

Diff [purge]

Index: branches/wmf/1.18wmf1/includes/resourceloader/ResourceLoaderContext.php
@@ -73,6 +73,8 @@
7474 */
7575 public static function expandModuleNames( $modules ) {
7676 $retval = array();
 77+ // For backwards compatibility with an earlier hack, replace ! with .
 78+ $modules = str_replace( '!', '.', $modules );
7779 $exploded = explode( '|', $modules );
7880 foreach ( $exploded as $group ) {
7981 if ( strpos( $group, ',' ) === false ) {
Index: branches/wmf/1.18wmf1/resources/mediawiki/mediawiki.js
@@ -1064,6 +1064,11 @@
10651065 return null;
10661066 };
10671067
 1068+ /**
 1069+ * For backwards-compatibility with Squid-cached pages. Loads mw.user
 1070+ */
 1071+ this.go = function() { mw.loader.load( 'mediawiki.user' ); };
 1072+
10681073 /* Cache document ready status */
10691074
10701075 $(document).ready( function() { ready = true; } );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r97607Accept ResourceLoader URLs containing '!' in '.' for backwards compatibility ...catrope09:13, 20 September 2011
r97608For backwards compatibility with cached HTML generated by MediaWiki 1.17, re-...catrope09:16, 20 September 2011

Status & tagging log