r97531 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r97530‎ | r97531 | r97532 >
Date:18:36, 19 September 2011
Author:sean_colombo
Status:reverted (Comments)
Tags:
Comment:
Merged in a fix from Wikia to make sure to call the ArticleDeleteComplete hook from deleteBatch (this is an existing hook that should be called on article deletion). Part of the diffs here: http://www.mediawiki.org/wiki/Wikia_code
Modified paths:
  • /trunk/phase3/maintenance/deleteBatch.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/deleteBatch.php
@@ -88,6 +88,8 @@
8989 $img = wfFindFile( $art->mTitle );
9090 if ( !$img || !$img->delete( $reason ) ) {
9191 $this->output( "FAILED to delete image file... " );
 92+ } else {
 93+ wfRunHooks('ArticleDeleteComplete', array(&$art, &$wgUser, $reason, $page_id));
9294 }
9395 } else {
9496 $art = new Article( $page );

Follow-up revisions

RevisionCommit summaryAuthorDate
r97547Revert r97531 -- hook call added that uses undefined local variables, will sp...brion20:07, 19 September 2011

Comments

#Comment by Reedy (talk | contribs)   20:04, 19 September 2011

$page_id is undefined on trunk

#Comment by 😂 (talk | contribs)   20:06, 19 September 2011

Also, this looks like a hack for behavior that should be fixed somewhere else...not sure we want this as-is in core.

Status & tagging log