r97532 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r97531‎ | r97532 | r97533 >
Date:18:38, 19 September 2011
Author:ialex
Status:ok
Tags:
Comment:
* Removed useless isset() check
* Added two spaces
Modified paths:
  • /trunk/phase3/includes/Linker.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Linker.php
@@ -888,10 +888,10 @@
889889 */
890890 public static function makeExternalLink( $url, $text, $escape = true, $linktype = '', $attribs = array() ) {
891891 $class = "external";
892 - if ( isset($linktype) && $linktype ) {
 892+ if ( $linktype ) {
893893 $class .= " $linktype";
894894 }
895 - if ( isset($attribs['class']) && $attribs['class'] ) {
 895+ if ( isset( $attribs['class'] ) && $attribs['class'] ) {
896896 $class .= " {$attribs['class']}";
897897 }
898898 $attribs['class'] = $class;

Status & tagging log