r97547 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r97546‎ | r97547 | r97548 >
Date:20:07, 19 September 2011
Author:brion
Status:ok (Comments)
Tags:
Comment:
Revert r97531 -- hook call added that uses undefined local variables, will spew E_NOTICE warnings when run.
Modified paths:
  • /trunk/phase3/maintenance/deleteBatch.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/deleteBatch.php
@@ -88,8 +88,6 @@
8989 $img = wfFindFile( $art->mTitle );
9090 if ( !$img || !$img->delete( $reason ) ) {
9191 $this->output( "FAILED to delete image file... " );
92 - } else {
93 - wfRunHooks('ArticleDeleteComplete', array(&$art, &$wgUser, $reason, $page_id));
9492 }
9593 } else {
9694 $art = new Article( $page );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r97531Merged in a fix from Wikia to make sure to call the ArticleDeleteComplete hoo...sean_colombo18:36, 19 September 2011

Comments

#Comment by SColombo~mediawikiwiki (talk | contribs)   20:29, 19 September 2011

Yikes, sorry. Thanks for the revert!

Status & tagging log