r97294 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r97293‎ | r97294 | r97295 >
Date:15:24, 16 September 2011
Author:jeroendedauw
Status:deferred
Tags:
Comment:
revert r97284; interface is proposed but does not exist yet - I failed
Modified paths:
  • /trunk/extensions/Maps/includes/features/Maps_BaseMap.php (modified) (history)
  • /trunk/extensions/Maps/includes/features/Maps_BasePointMap.php (modified) (history)
  • /trunk/extensions/Maps/includes/services/OSM/Maps_OSMDispMap.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Maps/includes/services/OSM/Maps_OSMDispMap.php
@@ -27,11 +27,7 @@
2828 'iframe',
2929 array(
3030 'id' => $mapName,
31 - 'style' => array(
32 - 'width' => $params['width'],
33 - 'height' => $params['height'],
34 - 'clear' => 'both'
35 - ),
 31+ 'style' => "width: {$params['width']}; height: {$params['height']}; clear: both;",
3632 'src' => "http://toolserver.org/~kolossos/openlayers/kml-on-ol.php?zoom={$params['zoom']}&lat={$params['centre']['lat']}&lon={$params['centre']['lon']}&lang=$lang&thumbs=$thumbs&photo=$photos"
3733 ),
3834 wfMsg( 'maps-loading-map' )
Index: trunk/extensions/Maps/includes/features/Maps_BasePointMap.php
@@ -76,12 +76,7 @@
7777 'div',
7878 array(
7979 'id' => $mapName,
80 - 'style' => array(
81 - 'width' => $params['width'],
82 - 'height' => $params['height'],
83 - 'background-color' => '#cccccc',
84 - 'overflow' => 'hidden'
85 - )
 80+ 'style' => "width: {$params['width']}; height: {$params['height']}; background-color: #cccccc; overflow: hidden;",
8681 ),
8782 wfMsg( 'maps-loading-map' )
8883 );
Index: trunk/extensions/Maps/includes/features/Maps_BaseMap.php
@@ -100,12 +100,7 @@
101101 'div',
102102 array(
103103 'id' => $mapName,
104 - 'style' => array(
105 - 'width' => $params['width'],
106 - 'height' => $params['height'],
107 - 'background-color' => '#cccccc',
108 - 'overflow' => 'hidden'
109 - )
 104+ 'style' => "width: {$params['width']}; height: {$params['height']}; background-color: #cccccc; overflow: hidden;",
110105 ),
111106 wfMsg( 'maps-loading-map' )
112107 );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r97284use style args that are escaped; not strictrly needed here as the vars have a...jeroendedauw15:04, 16 September 2011