r97098 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r97097‎ | r97098 | r97099 >
Date:20:42, 14 September 2011
Author:brion
Status:ok (Comments)
Tags:
Comment:
* (bug 30900) Remove confusing default value added for the default-don't-say-anything case of searchmenu-new-nocreate message

Reverts r80746's addition of a default value, removal of the message from the 'ignore' list, and the subsequent translations of this message that's supposed to be empty.
It doesn't make sense to have a default value here; as added in r65902 it was meant to default to empty. It's not very well thought out to begin with, so any message that goes it ends up being confusing. For queries that aren't meant to be page titles it's meaningless to begin with, and for users who aren't allowed to create articles at all due to read-only or edit/create restrictions it's even more confusing.
Modified paths:
  • /trunk/phase3/languages/messages/MessagesAf.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesAn.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesAr.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesAry.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesAst.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesAz.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesBar.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesBe.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesBe_tarask.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesBg.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesBjn.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesBr.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesBs.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesCa.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesCs.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesCy.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesDa.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesDe.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesDsb.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesDtp.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEl.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEo.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEs.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEt.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEu.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesFa.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesFi.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesFr.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesFrp.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesFur.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesGd.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesGl.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesGsw.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesHe.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesHif_latn.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesHil.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesHr.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesHsb.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesHu.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesIa.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesId.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesIe.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesInh.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesIo.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesIt.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesKrc.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesKsh.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesLad.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesLb.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesLez.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesLg.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesLi.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesLiv.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesLt.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesMg.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesMin.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesMk.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesMs.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesMt.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesNds.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesNds_nl.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesNl.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesNn.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesNo.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesNso.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesOc.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesOs.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesPms.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesPnb.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesPt.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesPt_br.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesQu.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesQug.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesRo.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesRoa_tara.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesRu.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesRue.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesSah.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesSco.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesSh.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesShi.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesSk.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesSl.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesSo.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesSq.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesSr_el.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesStq.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesSu.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesSv.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesSw.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesTl.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesTr.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesUg_arab.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesUk.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesVep.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesVi.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesYi.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesYue.php (modified) (history)
  • /trunk/phase3/maintenance/language/messageTypes.inc (modified) (history)

Follow-up revisions

RevisionCommit summaryAuthorDate
r97099MFT r97098: revert of r80746 to fix bug 30900brion20:46, 14 September 2011
r97173Merged revisions 97087,97091-97092,97094,97096-97098,97100-97101,97103,97136,...dantman16:19, 15 September 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r65902Add a new searchmenu-new-nocreate message...hartman15:36, 4 May 2010
r80746* changed 'searchmenu-new-nocreate' to no longer be ignored and have content....siebrand14:36, 22 January 2011

Comments

#Comment by Nikerabbit (talk | contribs)   05:24, 15 September 2011

These messages need to be deleted from twn too, to fix the bug there.

Status & tagging log