r97097 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r97096‎ | r97097 | r97098 >
Date:20:34, 14 September 2011
Author:brion
Status:reverted (Comments)
Tags:
Comment:
Revert r96824: causes fatal errors when search query doesn't happen to be a valid title. Code doesn't appear to have been tested?
Modified paths:
  • /trunk/extensions/WikimediaIncubator/IncubatorTest.php (modified) (history)
  • /trunk/extensions/WikimediaIncubator/WikimediaIncubator.i18n.php (modified) (history)
  • /trunk/extensions/WikimediaIncubator/WikimediaIncubator.php (modified) (history)
  • /trunk/phase3/docs/hooks.txt (modified) (history)
  • /trunk/phase3/includes/specials/SpecialSearch.php (modified) (history)

Diff [purge]

Index: trunk/phase3/docs/hooks.txt
@@ -1741,11 +1741,6 @@
17421742 &$query_options: array of options for the database request
17431743 &$select: Array of columns to select
17441744
1745 -'SpecialSearchCreateLink': called when making the message to create a page or
1746 -go to the existing page
1747 -$t: title object searched for
1748 -&$params: an array of the default message name and page title (as parameter)
1749 -
17501745 'SpecialSearchGo': called when user clicked the "Go"
17511746 &$title: title object generated from the text entered by the user
17521747 &$term: the search term entered by the user
@@ -1754,12 +1749,6 @@
17551750 target doesn't exist
17561751 &$title: title object generated from the text entered by the user
17571752
1758 -'SpecialSearchPowerBox': the equivalent of SpecialSearchProfileForm for
1759 -the advanced form, a.k.a. power search box
1760 -&$showSections: an array to add values with more options to
1761 -$term: the search term (not a title object)
1762 -$opts: an array of hidden options (containing 'redirs' and 'profile')
1763 -
17641753 'SpecialSearchProfiles': allows modification of search profiles
17651754 &$profiles: profiles, which can be modified.
17661755
Index: trunk/phase3/includes/specials/SpecialSearch.php
@@ -411,11 +411,8 @@
412412 $messageName = 'searchmenu-new-nocreate';
413413 }
414414 }
415 - $params = array( $messageName, wfEscapeWikiText( $t->getPrefixedText() ) );
416 - wfRunHooks( 'SpecialSearchCreateLink', array( $t, &$params ) );
417 -
418415 if( $messageName ) {
419 - $this->getOutput()->wrapWikiMsg( "<p class=\"mw-search-createlink\">\n$1</p>", $params );
 416+ $this->getOutput()->wrapWikiMsg( "<p class=\"mw-search-createlink\">\n$1</p>", array( $messageName, wfEscapeWikiText( $t->getPrefixedText() ) ) );
420417 } else {
421418 // preserve the paragraph for margins etc...
422419 $this->getOutput()->addHtml( '<p></p>' );
@@ -874,17 +871,13 @@
875872 }
876873 $namespaceTables .= Xml::closeElement( 'table' );
877874 }
878 -
879 - $showSections = array( 'namespaceTables' => $namespaceTables );
880 -
881875 // Show redirects check only if backend supports it
 876+ $redirects = '';
882877 if( $this->getSearchEngine()->supports( 'list-redirects' ) ) {
883 - $showSections['redirects'] =
 878+ $redirects =
884879 Xml::checkLabel( wfMsg( 'powersearch-redir' ), 'redirs', 'redirs', $this->searchRedirects );
885880 }
886881
887 - wfRunHooks( 'SpecialSearchPowerBox', array( &$showSections, $term, $opts ) );
888 -
889882 $hidden = '';
890883 unset( $opts['redirs'] );
891884 foreach( $opts as $key => $value ) {
@@ -920,8 +913,9 @@
921914 )
922915 ) .
923916 Xml::element( 'div', array( 'class' => 'divider' ), '', false ) .
924 - implode( Xml::element( 'div', array( 'class' => 'divider' ), '', false ), $showSections ) .
925 - $hidden .
 917+ $namespaceTables .
 918+ Xml::element( 'div', array( 'class' => 'divider' ), '', false ) .
 919+ $redirects . $hidden .
926920 Xml::closeElement( 'fieldset' );
927921 }
928922
Index: trunk/extensions/WikimediaIncubator/WikimediaIncubator.php
@@ -16,7 +16,7 @@
1717 'path' => __FILE__,
1818 'name' => 'Wikimedia Incubator',
1919 'author' => 'SPQRobin',
20 - 'version' => '4.5',
 20+ 'version' => '4.4',
2121 'url' => 'http://www.mediawiki.org/wiki/Extension:WikimediaIncubator',
2222 'descriptionmsg' => 'wminc-desc',
2323 );
@@ -149,8 +149,3 @@
150150 $wgHooks['SpecialListusersHeaderForm'][] = 'ListUsersTestWiki::onSpecialListusersHeaderForm';
151151 $wgHooks['SpecialListusersQueryInfo'][] = 'ListUsersTestWiki::onSpecialListusersQueryInfo';
152152 $wgHooks['SpecialListusersHeader'][] = 'ListUsersTestWiki::onSpecialListusersHeader';
153 -
154 -/* Search in test wiki */
155 -$wgHooks['SpecialSearchCreateLink'][] = 'IncubatorTest::onSpecialSearchCreateLink';
156 -$wgHooks['SpecialSearchPowerBox'][] = 'IncubatorTest::onSpecialSearchPowerBox';
157 -$wgHooks['SpecialSearchSetupEngine'][] = 'IncubatorTest::onSpecialSearchSetupEngine';
Index: trunk/extensions/WikimediaIncubator/IncubatorTest.php
@@ -35,7 +35,7 @@
3636 $prefinsert[$wmincPref . '-code'] = array(
3737 'type' => 'text',
3838 'section' => 'personal/i18n',
39 - 'label-message' => 'wminc-testwiki-code',
 39+ 'label-message' => 'wminc-testwiki',
4040 'id' => $wmincPref . '-code',
4141 'maxlength' => (int)$wmincLangCodeLength,
4242 'size' => (int)$wmincLangCodeLength,
@@ -695,62 +695,6 @@
696696 return true;
697697 }
698698
699 - /**
700 - * Search: Adapt the default message to show a more descriptive one,
701 - * along with an adapted link.
702 - * @return true
703 - */
704 - public static function onSpecialSearchCreateLink( $title, &$params ) {
705 - if( $title->isKnown() ) {
706 - return true;
707 - }
708 - global $wmincProjectSite, $wmincTestWikiNamespaces;
709 - $prefix = self::displayPrefix();
710 -
711 - $newNs = $title->getNamespace();
712 - $newTitle = $title->getText();
713 - if( $prefix == $wmincProjectSite['short'] ) {
714 - $newNs = NS_PROJECT;
715 - } else {
716 - if( !in_array( $title->getNamespace(), $wmincTestWikiNamespaces ) ) {
717 - $newNs = $wmincTestWikiNamespaces[0]; # no "valid" NS, should be main NS
718 - }
719 - $newTitle = $prefix . '/' . $newTitle;
720 - }
721 -
722 - $t = Title::newFromText( $newTitle, $newNs );
723 - if( $t->isKnown() ) {
724 - # use the default message if the suggested title exists
725 - $params[0] = 'searchmenu-exists';
726 - $params[1] = wfEscapeWikiText( $t->getPrefixedText() );
727 - return true;
728 - }
729 - $params[] = wfEscapeWikiText( $t->getPrefixedText() );
730 - $params[0] = $prefix ? 'wminc-search-nocreate-suggest' :'wminc-search-nocreate-nopref';
731 - return true;
732 - }
733 -
734 - /**
735 - * Search: Add an input form to enter a test wiki prefix.
736 - * @return true
737 - */
738 - public static function onSpecialSearchPowerBox( &$showSections, $term, $opts ) {
739 - $showSections['testwiki'] = Xml::label( wfMsg( 'wminc-testwiki' ), 'testwiki' ) . ' ' .
740 - Xml::input( 'testwiki', 20, self::displayPrefix(), array( 'id' => 'testwiki' ) );
741 - return true;
742 - }
743 -
744 - /**
745 - * Search: Search by default in the test wiki of the user's preference (or url &testwiki).
746 - * @return true
747 - */
748 - public static function onSpecialSearchSetupEngine( $search, $profile, $engine ) {
749 - if( !isset( $search->prefix ) || !$search->prefix ) {
750 - $search->prefix = self::displayPrefix();
751 - }
752 - return true;
753 - }
754 -
755699 private static function preg_quote_slash( $str ) {
756700 return preg_quote( $str, '/' );
757701 }
Index: trunk/extensions/WikimediaIncubator/WikimediaIncubator.i18n.php
@@ -16,7 +16,6 @@
1717 'wminc-manual' => 'Manual',
1818 'wminc-listwikis' => 'List of wikis',
1919 'wminc-testwiki' => 'Test wiki:',
20 - 'wminc-testwiki-code' => 'Test wiki language:',
2120 'wminc-testwiki-none' => 'None/All',
2221 'wminc-recentchanges-all' => 'All recent changes',
2322
@@ -58,10 +57,6 @@
5958
6059 # Special:ListUsers
6160 'wminc-listusers-testwiki' => 'You are viewing users who have set their test wiki preference to $1.',
62 -
63 - # Search
64 - 'wminc-search-nocreate-nopref' => 'You searched for "$1". Please set your [[Special:Preferences|test wiki preference]] so we can tell you which page you can create!',
65 - 'wminc-search-nocreate-suggest' => 'You searched for "$1". You can create a page in your wiki at <b>[[$2]]</b>!',
6661 );
6762
6863 /** Message documentation (Message documentation)

Follow-up revisions

RevisionCommit summaryAuthorDate
r97173Merged revisions 97087,97091-97092,97094,97096-97098,97100-97101,97103,97136,...dantman16:19, 15 September 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r96824SpecialSearch: add two hooks, one to modify the power search box, one to chan...robin01:39, 12 September 2011

Comments

#Comment by SPQRobin (talk | contribs)   17:54, 15 September 2011

r96824 is re-done in r97175. Marking this as reverted (not sure it that is the correct status).

Status & tagging log