r65902 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r65901‎ | r65902 | r65903 >
Date:15:36, 4 May 2010
Author:hartman
Status:ok
Tags:
Comment:
Add a new searchmenu-new-nocreate message

This message is shown when no title matches the searchterm and when the user is not allowed to create pages either.
The message is empty be default and balances r61555 from bug 19600.

See also the related bug 20976
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/specials/SpecialSearch.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesQqq.php (modified) (history)
  • /trunk/phase3/maintenance/language/messages.inc (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/language/messages.inc
@@ -804,6 +804,7 @@
805805 'searchmenu-legend',
806806 'searchmenu-exists',
807807 'searchmenu-new',
 808+ 'searchmenu-new-nocreate',
808809 'searchhelp-url',
809810 'searchmenu-prefix',
810811 'searchmenu-help',
Index: trunk/phase3/includes/specials/SpecialSearch.php
@@ -327,6 +327,8 @@
328328 $messageName = 'searchmenu-exists';
329329 } elseif( $t->userCan( 'create' ) ) {
330330 $messageName = 'searchmenu-new';
 331+ } else {
 332+ $messageName = 'searchmenu-new-nocreate';
331333 }
332334 }
333335 if( $messageName ) {
Index: trunk/phase3/languages/messages/MessagesQqq.php
@@ -1121,6 +1121,7 @@
11221122 'searchmenu-legend' => '{{Identical|Search options}}',
11231123 'searchmenu-exists' => 'An option shown in a menu beside search form offering a link to the existing page having the specified title (when using the default MediaWiki search engine).',
11241124 'searchmenu-new' => 'An option shown in a menu beside search form offering a red link to the not yet existing page having the specified title (when using the default MediaWiki search engine).',
 1125+'searchmenu-new-nocreate' => 'An option shown in a menu beside search form when users are not allowed to create new pages (when using the default MediaWiki search engine).',
11251126 'searchhelp-url' => '{{Identical|HelpContent}}
11261127 Description: The URL of the search help page.
11271128 {{doc-important|Do not change "Help:" part.}}',
Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -1611,6 +1611,7 @@
16121612 'searchmenu-legend' => 'Search options',
16131613 'searchmenu-exists' => "'''There is a page named \"[[:\$1]]\" on this wiki'''",
16141614 'searchmenu-new' => "'''Create the page \"[[:\$1]]\" on this wiki!'''",
 1615+'searchmenu-new-nocreate' => '', # do not translate or duplicate this message to other languages
16151616 'searchhelp-url' => 'Help:Contents',
16161617 'searchmenu-prefix' => '[[Special:PrefixIndex/$1|Browse pages with this prefix]]',
16171618 'searchmenu-help' => '[[{{MediaWiki:Searchhelp-url}}|{{int:help}}]]?', # do not translate or duplicate this message to other languages
Index: trunk/phase3/RELEASE-NOTES
@@ -65,6 +65,8 @@
6666 which causes Vector to render the variants drop-down menu with a label
6767 showing the current variant name. This is off by default, pending further
6868 research into its user experience implications.
 69+* (bug 20976) "searchmenu-new-nocreate" message now displayed when when there
 70+ is no title match in search and the user has no rights to create pages.
6971
7072 === Bug fixes in 1.17 ===
7173 * (bug 17560) Half-broken deletion moved image files to deletion archive

Follow-up revisions

RevisionCommit summaryAuthorDate
r65903Set searchmenu-new-nocreate as an ignorable message....hartman15:40, 4 May 2010
r80746* changed 'searchmenu-new-nocreate' to no longer be ignored and have content....siebrand14:36, 22 January 2011
r97098* (bug 30900) Remove confusing default value added for the default-don't-say-...brion20:42, 14 September 2011
r97173Merged revisions 97087,97091-97092,97094,97096-97098,97100-97101,97103,97136,...dantman16:19, 15 September 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r61555(bug 19600) don't display searchmenu-new when user has not got permission to...conrad03:06, 27 January 2010

Status & tagging log