r96472 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r96471‎ | r96472 | r96473 >
Date:19:14, 7 September 2011
Author:bawolff
Status:ok
Tags:
Comment:
$wgOverrideSiteFeed was double escaping urls (noticed in bug 30621).

(aka it was giving things with & in them :s )
Modified paths:
  • /trunk/phase3/RELEASE-NOTES-1.18 (modified) (history)
  • /trunk/phase3/includes/OutputPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/RELEASE-NOTES-1.18
@@ -443,6 +443,7 @@
444444 * (bug 30074) Moving user JS subpages resulted in JS errors because
445445 #REDIRECT [[Foo]] is invalid JS
446446 * Tracking categories are no longer shown in footer for special pages
 447+* $wgOverrideSiteFeed no longer double escapes urls.
447448
448449 === API changes in 1.18 ===
449450 * BREAKING CHANGE: action=watch now requires POST and token.
Index: trunk/phase3/includes/OutputPage.php
@@ -2885,9 +2885,10 @@
28862886
28872887 if ( $wgOverrideSiteFeed ) {
28882888 foreach ( $wgOverrideSiteFeed as $type => $feedUrl ) {
 2889+ // Note, this->feedLink escapes the url.
28892890 $tags[] = $this->feedLink(
28902891 $type,
2891 - htmlspecialchars( $feedUrl ),
 2892+ $feedUrl,
28922893 wfMsg( "site-{$type}-feed", $wgSitename )
28932894 );
28942895 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r96480MFT r96472reedy19:47, 7 September 2011
r965121.18: MFT r95655, r96227, r96386, r96393, r96405, r96427, r96460, r96472. And...catrope22:18, 7 September 2011

Status & tagging log