r96393 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r96392‎ | r96393 | r96394 >
Date:01:12, 7 September 2011
Author:dantman
Status:ok
Tags:
Comment:
Followup r96217, slight regression use rawElement not element, accidentally caused the <a> to be htmlescaped.
Modified paths:
  • /trunk/phase3/includes/SkinTemplate.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SkinTemplate.php
@@ -490,7 +490,7 @@
491491
492492 // Append printfooter and debughtml onto bodytext so that skins that were already
493493 // using bodytext before they were split out don't suddenly start not outputting information
494 - $tpl->data['bodytext'] .= Html::element( 'div', array( 'class' => 'printfooter' ), "\n{$tpl->data['printfooter']}" ) . "\n";
 494+ $tpl->data['bodytext'] .= Html::rawElement( 'div', array( 'class' => 'printfooter' ), "\n{$tpl->data['printfooter']}" ) . "\n";
495495 $tpl->data['bodytext'] .= $tpl->data['debughtml'];
496496
497497 // allow extensions adding stuff after the page content.

Follow-up revisions

RevisionCommit summaryAuthorDate
r965121.18: MFT r95655, r96227, r96386, r96393, r96405, r96427, r96460, r96472. And...catrope22:18, 7 September 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r96217Followup r87340: Post-hook swap bodytext into a new bodycontent key and appen...dantman12:38, 4 September 2011

Status & tagging log