r96480 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r96479‎ | r96480 | r96481 >
Date:19:47, 7 September 2011
Author:reedy
Status:ok
Tags:
Comment:
MFT r96472
Modified paths:
  • /branches/wmf/1.17wmf1/includes/OutputPage.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.17wmf1/includes/OutputPage.php
@@ -2669,9 +2669,10 @@
26702670
26712671 if ( $wgOverrideSiteFeed ) {
26722672 foreach ( $wgOverrideSiteFeed as $type => $feedUrl ) {
 2673+ // Note, this->feedLink escapes the url.
26732674 $tags[] = $this->feedLink(
26742675 $type,
2675 - htmlspecialchars( $feedUrl ),
 2676+ $feedUrl,
26762677 wfMsg( "site-{$type}-feed", $wgSitename )
26772678 );
26782679 }
Property changes on: branches/wmf/1.17wmf1/includes/OutputPage.php
___________________________________________________________________
Modified: svn:mergeinfo
26792680 Merged /trunk/phase3/includes/OutputPage.php:r96472

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r96472$wgOverrideSiteFeed was double escaping urls (noticed in bug 30621)....bawolff19:14, 7 September 2011

Status & tagging log