r96340 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r96339‎ | r96340 | r96341 >
Date:15:15, 6 September 2011
Author:jeroendedauw
Status:resolved (Comments)
Tags:todo 
Comment:
categories in the wikitext output should not have underscores instead of spaces
Modified paths:
  • /trunk/extensions/UploadWizard/resources/jquery/jquery.mwCoolCats.js (modified) (history)

Diff [purge]

Index: trunk/extensions/UploadWizard/resources/jquery/jquery.mwCoolCats.js
——@@ -212,7 +212,7 @@
213213 });
214214
215215 this.getWikiText = function() {
216 - var wikiText = _getCats().map( function() { return '[[' + this.toString() + ']]'; } )
 216+ var wikiText = _getCats().map( function() { return '[[' + this.getMainText() + ']]'; } )
217217 .toArray()
218218 .join( "\n" );
219219

Follow-up revisions

RevisionCommit summaryAuthorDate
r96918fix: add missing category prefixjeroendedauw21:56, 12 September 2011

Comments

#Comment by Krinkle (talk | contribs)   22:07, 12 September 2011

This revision broke categorylinks (splitting out [[links]] instead of [[Category:Links]]). Fixed in r96918.

Still needs fixing on Commons:

http://commons.wikimedia.org/wiki/Special:WhatLinksHere/Uploaded_with_UploadWizard

The files in the above links have all categorylinks without the prefix (not just the "Uploaded_with_UploadWizard" category, but also any categories added by users through the UploadWizard interface (such as this one

#Comment by Jeroen De Dauw (talk | contribs)   22:40, 12 September 2011

Reedy fixed it w/ a hack in the deploy branch: r96917

Status & tagging log