r96339 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r96338‎ | r96339 | r96340 >
Date:15:05, 6 September 2011
Author:jeroendedauw
Status:ok
Tags:
Comment:
follow up to r96338
Modified paths:
  • /trunk/extensions/UploadWizard/includes/UploadWizardCampaign.php (modified) (history)
  • /trunk/extensions/UploadWizard/includes/specials/SpecialUploadCampaign.php (modified) (history)

Diff [purge]

Index: trunk/extensions/UploadWizard/includes/specials/SpecialUploadCampaign.php
@@ -106,7 +106,7 @@
107107 if ( is_array( $data['default'] ) ) {
108108 switch ( $data['type'] ) {
109109 case 'text': case 'textarea':
110 - $data['default'] = implode( '| ', $data['default'] );
 110+ $data['default'] = implode( '|', $data['default'] );
111111 break;
112112 }
113113 }
Index: trunk/extensions/UploadWizard/includes/UploadWizardCampaign.php
@@ -301,7 +301,7 @@
302302
303303 foreach ( $config as $settingName => &$settingValue ) {
304304 if ( is_array( $defaultConfig[$settingName]['default'] ) && !is_array( $settingValue ) ) {
305 - $parts = explode( '| ', $settingValue );
 305+ $parts = explode( '|', $settingValue );
306306 $settingValue = array();
307307
308308 foreach ( $parts as $part ) {
@@ -494,13 +494,15 @@
495495
496496 $dbw->begin();
497497
 498+ // TODO: it'd be better to serialize() arrays
 499+
498500 foreach ( $this->config as $prop => $value ) {
499501 $success &= $dbw->insert(
500502 'uw_campaign_conf',
501503 array(
502504 'cc_campaign_id' => $this->id,
503505 'cc_property' => $prop,
504 - 'cc_value' => is_array( $value ) ? implode( '| ', $value ) : $value
 506+ 'cc_value' => is_array( $value ) ? implode( '|', $value ) : $value
505507 ),
506508 __METHOD__
507509 );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r96338fix issue; comma delimiter was changed to pipe, but not here apparentlyjeroendedauw14:59, 6 September 2011

Status & tagging log