r96341 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r96340‎ | r96341 | r96342 >
Date:15:20, 6 September 2011
Author:maxsem
Status:ok
Tags:
Comment:
Even on Windows, some people have diff ;)
Modified paths:
  • /trunk/phase3/tests/parser/parserTest.inc (modified) (history)

Diff [purge]

Index: trunk/phase3/tests/parser/parserTest.inc
@@ -1068,7 +1068,9 @@
10691069 $shellInfile = wfEscapeShellArg($infile);
10701070 $shellOutfile = wfEscapeShellArg($outfile);
10711071
1072 - $diff = wfIsWindows()
 1072+ global $wgDiff3;
 1073+ // we assume that people with diff3 also have usual diff
 1074+ $diff = ( wfIsWindows() && !$wgDiff3 )
10731075 ? `fc $shellInfile $shellOutfile`
10741076 : `diff -au $shellInfile $shellOutfile`;
10751077 unlink( $infile );

Status & tagging log