r96228 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r96227‎ | r96228 | r96229 >
Date:14:28, 4 September 2011
Author:catrope
Status:ok
Tags:
Comment:
(bug 30735) Use protocol-relative URL for geoiplookup. Should not be deployed until bug 30330 (geoip returns bad data over HTTPS) is fixed.
Modified paths:
  • /trunk/extensions/CentralNotice/CentralNotice.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CentralNotice/CentralNotice.php
——@@ -196,7 +196,7 @@
197197
198198 function efCentralNoticeGeoLoader( $skin, &$text ) {
199199 // Insert the geo IP lookup
200 - $text .= '<script type="text/javascript" src="http://geoiplookup.wikimedia.org/"></script>';
 200+ $text .= '<script type="text/javascript" src="//geoiplookup.wikimedia.org/"></script>';
201201 return true;
202202 }
203203

Follow-up revisions

RevisionCommit summaryAuthorDate
r963601.17wmf1: MFT r96180, r96228, r96273, r96286catrope19:11, 6 September 2011
r964851.18: MFT protocol-relative URL saga: r95014, r95016, r95017, r95627, r95651,...catrope20:14, 7 September 2011

Status & tagging log