r95651 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r95650‎ | r95651 | r95652 >
Date:08:55, 29 August 2011
Author:catrope
Status:ok
Tags:
Comment:
In WikiMap, pull wgCanonicalServer from $wgConf instead of wgServer for building URLs to foreign wikis. This means wgCanonicalServer is now expected to always be available in wgConf; document this in RELEASE-NOTES (-1.18 because this is for backporting).
Modified paths:
  • /trunk/phase3/RELEASE-NOTES-1.18 (modified) (history)
  • /trunk/phase3/includes/WikiMap.php (modified) (history)

Diff [purge]

Index: trunk/phase3/RELEASE-NOTES-1.18
@@ -621,6 +621,8 @@
622622 * Removed legacy wgAjaxWatch javascript global object, no longer in use.
623623 * (bug 28556) Upload support for MacBinary files has been removed (Used by
624624 Internet Explorer 5 for Mac OS 9)
 625+* On wiki farm setups using $wgConf, 'wgCanonicalServer' is now expected to be
 626+ set for all wikis. This was already the case for 'wgServer'.
625627
626628 == Compatibility ==
627629
Index: trunk/phase3/includes/WikiMap.php
@@ -18,7 +18,7 @@
1919
2020 list( $major, $minor ) = $wgConf->siteFromDB( $wikiID );
2121 if( isset( $major ) ) {
22 - $server = $wgConf->get( 'wgServer', $wikiID, $major,
 22+ $server = $wgConf->get( 'wgCanonicalServer', $wikiID, $major,
2323 array( 'lang' => $minor, 'site' => $major ) );
2424 $path = $wgConf->get( 'wgArticlePath', $wikiID, $major,
2525 array( 'lang' => $minor, 'site' => $major ) );

Follow-up revisions

RevisionCommit summaryAuthorDate
r95663Last commit to make WMF-deployed extensions HTTPS-ready (hopefully): use wfEx...catrope14:37, 29 August 2011
r959011.17wmf1: MFT HTTPS / prot rel URL fixes: r95627, r95651, r95652, r95653, r95...catrope19:15, 31 August 2011
r964851.18: MFT protocol-relative URL saga: r95014, r95016, r95017, r95627, r95651,...catrope20:14, 7 September 2011

Status & tagging log